From kde-kimageshop Tue Mar 10 08:50:53 2020 From: Boudewijn Rempt Date: Tue, 10 Mar 2020 08:50:53 +0000 To: kde-kimageshop Subject: Re: Failing unittest: KisAutoBrushTest Message-Id: <1748468.tdWV9SEqCh () boud-thinkpad-t470p> X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=158383026525974 Caused by commit 43b517002bbc719a0a7eae6261f555a1e671e4a7 (HEAD -> master, origin/master, origin/HEAD) Author: Dmitry Kazakov Date: Tue Mar 10 01:04:42 2020 +0300 Fix offset of transformed shapes after copy-paste BUG:417183 On vrijdag 6 maart 2020 12:02:57 CET Boudewijn Rempt wrote: > This test started failing recently (in master): > > ********* Start testing of KisAutoBrushTest ********* > Config: Using QtTest library 5.14.1, Qt 5.14.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0) > PASS : KisAutoBrushTest::initTestCase() > PASS : KisAutoBrushTest::testCreation() > PASS : KisAutoBrushTest::testMaskGeneration() > QDEBUG : KisAutoBrushTest::testDabSize() "Identity" > QDEBUG : KisAutoBrushTest::testDabSize() "Double" > QDEBUG : KisAutoBrushTest::testDabSize() "Halve" > QDEBUG : KisAutoBrushTest::testDabSize() "180 deg" > QDEBUG : KisAutoBrushTest::testDabSize() "90 deg" > QDEBUG : KisAutoBrushTest::testDabSize() "-90 deg" > QDEBUG : KisAutoBrushTest::testDabSize() "45 deg" > QDEBUG : KisAutoBrushTest::testDabSize() "2x, 45d" > QDEBUG : KisAutoBrushTest::testDabSize() "0.5x, 45d" > QDEBUG : KisAutoBrushTest::testDabSize() "0.5x, 45d" > QDEBUG : KisAutoBrushTest::testDabSize() "0.5y" > FAIL! : KisAutoBrushTest::testDabSize() Compared values are not the same > Actual (brush->maskHeight(shape, 0.0, 0.0, KisPaintInformation())): 3 > Expected (expectedHeight) : 5 > Loc: [/home/boud/dev/krita/libs/brush/tests/kis_auto_brush_test.cpp(99)] > QWARN : KisAutoBrushTest::testCopyMasking() KoColor debug runtime checks are active. > PASS : KisAutoBrushTest::testCopyMasking() > PASS : KisAutoBrushTest::testClone() > PASS : KisAutoBrushTest::cleanupTestCase() > Totals: 6 passed, 1 failed, 0 skipped, 0 blacklisted, 121ms > ********* Finished testing of KisAutoBrushTest ********* > > -- https://www.krita.org