[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Overview docker - slight changes
From: Boudewijn Rempt <boud () valdyas ! org>
Date: 2018-08-20 8:20:56
Message-ID: 7912286.Iu2pWjtSHK () boud-thinkpad-t470p
[Download RAW message or body]
Hi Isaac,
Great to see you've started hacking :-) I've turned your changes into a proper
patch and put it on phabricator, which is where we do code review. If you
continue hacking, please make a KDE identity and put your changes there as
well. See https://phabricator.kde.org/D14943
As it is, there are some problems with the patch: as you noted in the
comments, changing the update frequency of KisIdleWatcher will have an impact
on the system's performance.
On maandag 20 augustus 2018 06:37:44 CEST Isaac Zuniga wrote:
> Hello KDE and/or Krita development team,
>
> My name is Isaac Zuniga. I have been using Krita for the past few years, and
> it has been quite a fun few years using Krita. I felt bad for all those
> years because of my classes getting in the way. I've wanted to contribute
> to the development of Krita by any means. Recently, I took up a little bit
> of programming and I was able to "refine" a few requests I asked for on the
> KDE bugtracker.
> I was able to use the source files of Krita on my Linux machine to compile
> the Linux version of Krita. I only altered the 2 attached files. While
> working on what I was looking for, a cleaner overview widget, I discovered
> a few things that I was unable to tackle myself. One of them being to scale
> up an image in the docker. For example, if the canvas is smaller than the
> draw area in the docker, it will not "scale up" the image. Interestingly,
> when you resize the docker, it shows a temporary image of the entire window
> being filled up by the canvas.
> I understand that this is for the community, by the community, and I think
> that it's best I let someone else with more programming knowledge than I do
> to tackle that issue. I left notes in the files attached with my name next
> to them, so you can see what I discovered and/or found out by playing
> around with a few bits of the code.
> I realize that this is the Linux version, and Windows may or may not handle
> my changes (especially OSX). With that being said, if any of it needs to be
> changed, please do not hesitate in doing so!
> Sincerely,
>
> Isaac Zuniga
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic