[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Need help with testing asynchronous saving branch! :)
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2017-07-29 7:24:11
Message-ID: 92583dd5-7825-4808-8136-5bce6ec78163 () gmail ! com
[Download RAW message or body]
Hi, Alvin!
Thank you very much for your testing. I actually forgot about this flag,
so it saved the mergedimage as well.
I have fixed it, and now it shouldn't save the stuff anymore:
https://commits.kde.org/krita/27a9873aba0be3816a406027ab8d3ac298a884e7
On 28.07.2017 20:53, Alvin Wong wrote:
> Hi Dmitry,
>
> I've tested it for a short while on Windows with the python branch
> merged in (so using Qt 5.9.1) with multiple files opened and the
> autosave seems to work nicely, saving works, no crashes or lockups.
>
> It's not a lot of in-depth testing but my impression is pretty good!
>
> One thing I noticed is that the autosaved file contains
> `mergedimage.png` and `preview.png`. Autosaves on 3.2 beta 2 seems to
> only saves `preview.png` (and I seem to remember earlier versions
> (probably during the 3.0 times) not even having `preview.png`). Would
> it cause undesirable overhead during autosaving or is it intended?
>
> Best Regards,
>
> Alvin Wong
>
> 2017-07-27 23:26 GMT+08:00 Dmitry Kazakov <dimula73@gmail.com>:
>> Hi, all!
>>
>> I have fixed all your previous reports! Please test the branch again! If no
>> severe regressions found, I will merge it to master :)
>>
>> To test do:
>>
>> git checkout kazakov/async-saving
>>
>> and build as usual :)
>>
>>
>> The issues can be tracked here:
>> https://phabricator.kde.org/T6542
>>
>>
>>
>>
>> --
>> Dmitry Kazakov
--
Dmitry Kazakov
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><font size="-1">Hi, Alvin!</font></p>
<font size="-1">Thank you very much for your testing. I actually
forgot about this flag, so it saved the mergedimage as well.<br>
</font><br>
<font size="-1">I have fixed it, and now it shouldn't save the stuff
anymore:</font><br>
<font size="-1"><a class="moz-txt-link-freetext" \
href="https://commits.kde.org/krita/27a9873aba0be3816a406027ab8d3ac298a884e7">https://commits.kde.org/krita/27a9873aba0be3816a406027ab8d3ac298a884e7</a><br>
</font><br>
<br>
<br>
<div class="moz-cite-prefix">On 28.07.2017 20:53, Alvin Wong wrote:<br>
</div>
<blockquote
cite="mid:CAE_6Y7EtjD8eOLpRyvBb--+GKCDEaHN7Ue6CGcDA_H3u2+Jr1g@mail.gmail.com"
type="cite">
<pre wrap="">Hi Dmitry,
I've tested it for a short while on Windows with the python branch
merged in (so using Qt 5.9.1) with multiple files opened and the
autosave seems to work nicely, saving works, no crashes or lockups.
It's not a lot of in-depth testing but my impression is pretty good!
One thing I noticed is that the autosaved file contains
`mergedimage.png` and `preview.png`. Autosaves on 3.2 beta 2 seems to
only saves `preview.png` (and I seem to remember earlier versions
(probably during the 3.0 times) not even having `preview.png`). Would
it cause undesirable overhead during autosaving or is it intended?
Best Regards,
Alvin Wong
2017-07-27 23:26 GMT+08:00 Dmitry Kazakov <a class="moz-txt-link-rfc2396E" \
href="mailto:dimula73@gmail.com"><dimula73@gmail.com></a>: </pre>
<blockquote type="cite">
<pre wrap="">Hi, all!
I have fixed all your previous reports! Please test the branch again! If no
severe regressions found, I will merge it to master :)
To test do:
git checkout kazakov/async-saving
and build as usual :)
The issues can be tracked here:
<a class="moz-txt-link-freetext" \
href="https://phabricator.kde.org/T6542">https://phabricator.kde.org/T6542</a>
--
Dmitry Kazakov
</pre>
</blockquote>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Dmitry Kazakov</pre>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic