[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Review Request 129898: Fix: activate "next/previous layer" shorcut for layers or group which are
From: Aniketh Girish <anikethgireesh () gmail ! com>
Date: 2017-01-28 17:57:57
Message-ID: 20170128175757.28168.88441 () mimi ! kde ! org
[Download RAW message or body]
--===============5984173589467945537==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 28, 2017, 3:33 p.m., Dmitry Kazakov wrote:
> > Could you tell what does this patch do? As far as I can see from the patch, it \
> > basically disables the isEditable() check, because (!A || A) is always true.
> > And please next time use https://phabricator.kde.org/differential/ for Krita \
> > patches.
Damn! What I did is really wrong. Sorry. My bad. So, As of now what I see is that, \
the condition should return true value to engage the working of the shortcuts. So why \
do we need to check if that node is isEditable() or not. Even its not editable we \
should be able to enter that group right? Will creating a condition inside the \
"while" loop and the existing condition "if" to check if the node is not isEditable() \
to return the required output ?
Also sorry for posting the review request over here. As I am unable to authenticate \
to phabricator with my KDE identity credentials.
- Aniketh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129898/#review102303
-----------------------------------------------------------
On Jan. 28, 2017, 2:16 p.m., Aniketh Girish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129898/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2017, 2:16 p.m.)
>
>
> Review request for Krita Extensions and Boudewijn Rempt.
>
>
> Bugs: 336899
> https://bugs.kde.org/show_bug.cgi?id=336899
>
>
> Repository: krita
>
>
> Description
> -------
>
> use PgDn, PgUp as shortcuts to move through the invisible layers inside a group.
>
>
> Diffs
> -----
>
> libs/ui/kis_node_manager.cpp 9dba112
>
> Diff: https://git.reviewboard.kde.org/r/129898/diff/
>
>
> Testing
> -------
>
> Checked by building it.
>
>
> Thanks,
>
> Aniketh Girish
>
>
--===============5984173589467945537==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129898/">https://git.reviewboard.kde.org/r/129898/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 28th, 2017, 3:33 p.m. UTC, <b>Dmitry \
Kazakov</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Could you tell what does this patch do? As far as I \
can see from the patch, it basically disables the isEditable() check, because (!A || \
A) is always true.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">And please next time use \
https://phabricator.kde.org/differential/ for Krita patches.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Damn! \
What I did is really wrong. Sorry. My bad. So, As of now what I see is that, the \
condition should return true value to engage the working of the shortcuts. So why do \
we need to check if that node is isEditable() or not. Even its not editable we should \
be able to enter that group right? Will creating a condition inside the "while" loop \
and the existing condition "if" to check if the node is not isEditable() to return \
the required output ?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also sorry for posting the review \
request over here. As I am unable to authenticate to phabricator with my KDE identity \
credentials.</p></pre> <br />
<p>- Aniketh</p>
<br />
<p>On January 28th, 2017, 2:16 p.m. UTC, Aniketh Girish wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Krita Extensions and Boudewijn Rempt.</div>
<div>By Aniketh Girish.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2017, 2:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=336899">336899</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
krita
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">use PgDn, PgUp as shortcuts to move through the \
invisible layers inside a group.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Checked by building it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/ui/kis_node_manager.cpp <span style="color: grey">(9dba112)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129898/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5984173589467945537==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic