[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [krita/video-export-rebased] libs/ui: Save to a temporary file, then copy the result over on suc
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2016-08-17 8:03:43
Message-ID: CAEkBSfWYuFn+kv13-nAeo0o+bWQQZHtTm7yBXAQq9icTt8E0zA () mail ! gmail ! com
[Download RAW message or body]

On Tue, Aug 16, 2016 at 7:12 PM, Boudewijn Rempt <boud@valdyas.org> wrote:

> On Tue, 16 Aug 2016, Dmitry Kazakov wrote:
>
> > Can we somehow limit this behavior to network files only?
>
> I would prefer not to. This also solves the issue we've seen where a
> failure to save breaks the original file.


That is a good point, yes.


> > 1) If some other application, like Blender, is waiting on Krita-edited
> file
> > with inotify (QFileSystemWatcher), it may go crazy when we rename and
> > delete the file. The inotify opject will be destroyed after that.
>
> Did you test that, or is this just a hunch?
>

Just a hunch. Needs to be tested before the merge.


>
> > 2) What if the user works with 700MiB image? It mean he needs twice the
> > size of the image free space just to be able to save it. Many people will
> > be unhappy with it.
>
> But far fewer people than are currently unhappy because our unsafe saving
> code breaks their files. And if the file hasn't been saved before there is
> no extra disk space needed,


I agree, then we should probably have some clever choice of the temporary
file folder? Like "if the saving to /tmp failed due to the lack of space,
try saving into the same directory as the destination file". That will
solve the issue for people who have different partitions for /home and /.
Or just make it configurable somehow...

I know a lot of people who give quite small partitions to Windows (~50GiB)
and use a separate partitions/drives for their working folders.

[Attachment #3 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug \
16, 2016 at 7:12 PM, Boudewijn Rempt <span dir="ltr">&lt;<a \
href="mailto:boud@valdyas.org" target="_blank">boud@valdyas.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span class="">On Tue, 16 Aug 2016, Dmitry Kazakov \
wrote:<br> <br>
&gt; Can we somehow limit this behavior to network files only?<br>
<br>
</span>I would prefer not to. This also solves the issue we&#39;ve seen where a<br>
failure to save breaks the original file.</blockquote><div><br></div><div>That is a \
good point, yes.<br></div><div>  <br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <span \
class="">&gt; 1) If some other application, like Blender, is waiting on Krita-edited \
file<br> &gt; with inotify (QFileSystemWatcher), it may go crazy when we rename \
and<br> &gt; delete the file. The inotify opject will be destroyed after that.<br>
<br>
</span>Did you test that, or is this just a \
hunch?<br></blockquote><div><br></div><div>Just a hunch. Needs to be tested before \
the merge.<br></div><div>  </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <span class=""><br>
&gt; 2) What if the user works with 700MiB image? It mean he needs twice the<br>
&gt; size of the image free space just to be able to save it. Many people will<br>
&gt; be unhappy with it.<br>
<br>
</span>But far fewer people than are currently unhappy because our unsafe saving<br>
code breaks their files. And if the file hasn&#39;t been saved before there is<br>
no extra disk space needed,</blockquote><div><br></div><div>I agree, then we should \
probably have some clever choice of the temporary file folder? Like &quot;if the \
saving to /tmp failed due to the lack of space, try saving into the same directory as \
the destination file&quot;. That will solve the issue for people who have different \
partitions for /home and /. Or just make it configurable \
somehow...<br><br></div><div>I know a lot of people who give quite small partitions \
to Windows (~50GiB) and use a separate partitions/drives for their working \
folders.<br></div><div><br>  </div></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]