'Re: Review Request 128020: Use the standard naming scheme for the appdata files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Review Request 128020: Use the standard naming scheme for the appdata files
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2016-06-02 18:19:35
Message-ID: 20160602181935.29452.60197 () mimi ! kde ! org
[Download RAW message or body]

--===============6226411961471873654==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128020/#review96157
-----------------------------------------------------------

Ship it!

I still am clueless quite a bit, but if Matthias says it's fine, it's fine with me as \
well. Note that if you want to make flatpaks of 3.0, this also should be pushed to \
the krita/3.0 branch.

- Boudewijn Rempt

On June 2, 2016, 4:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128020/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 4:08 p.m.)
> 
> 
> Review request for Krita Extensions and Boudewijn Rempt.
> 
> 
> Repository: krita
> 
> 
> Description
> -------
> 
> As suggested here: \
> https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
>  
> I also had to rename the desktop file, otherwise flatpak choked on it: \
> http://commits.kde.org/scratch/apol/xdgapp-nightly-apps/94c586069573ed781725fc655b9a1b5b7f8f8a59
>  
> 
> Diffs
> -----
> 
> krita/CMakeLists.txt a546a8d 
> krita/krita.appdata.xml cee1660 
> krita/krita.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/128020/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

--===============6226411961471873654==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128020/">https://git.reviewboard.kde.org/r/128020/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
still am clueless quite a bit, but if Matthias says it's fine, it's fine with me as \
well. Note that if you want to make flatpaks of 3.0, this also should be pushed to \
the krita/3.0 branch.</p></pre>  <br />

<p>- Boudewijn Rempt</p>

<br />
<p>On June 2nd, 2016, 4:08 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Krita Extensions and Boudewijn Rempt.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated June 2, 2016, 4:08 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
krita
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As suggested here: \
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent</p>
 <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I also had to rename the desktop file, otherwise \
flatpak choked on it: \
http://commits.kde.org/scratch/apol/xdgapp-nightly-apps/94c586069573ed781725fc655b9a1b5b7f8f8a59</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/CMakeLists.txt <span style="color: grey">(a546a8d)</span></li>

 <li>krita/krita.appdata.xml <span style="color: grey">(cee1660)</span></li>

 <li>krita/krita.desktop <span style="color: grey">()</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128020/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6226411961471873654==--

[Attachment #3 (text/plain)]

_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

[prev in list] [next in list] [prev in thread] [next in thread] 