[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Non-Vc builds broken (Re: [krita] /: Update krita to compile against Vc >= 1.0.0)
From: Fazekas_László <mneko () freemail ! hu>
Date: 2016-04-10 14:23:11
Message-ID: 570A61CF.6090308 () freemail ! hu
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hello,
I compiled Krita with Ubuntu 14.04 until the Vc change, then I wasn't
able to build it anymore. I completely dropped the 14.04 system and
installing 16.04 right now. Maybe it was my fault, but this change was a
big problem on my Linux too.
Fazek
2016-04-10 13:59 keltezéssel, Boudewijn Rempt Ãrta:
> On Sun, 10 Apr 2016, Dmitry Kazakov wrote:
>
>> Erm... I would really expect that the version without Vc would go
>> into a separate branch, not doing any reverts in master. Now you made
>> all the people who already built Vc 1.2 rebuild Krita again and waste
>> about an hour of their time.
>
> Yes, I realize that. But:
>
> * CI was broken too
> * Windows builds from master were impossible
> * Raghukamath reported a big performance issue
>
> All together, that was enough for me to decide that we need to work on
> these issues in a branch and make master stable again.
>
> Boudewijn
>
>
>>
>> On Sat, Apr 9, 2016 at 1:39 PM, Boudewijn Rempt <boud@valdyas.org>
>> wrote:
>> Making the build work without Vc was too tricky for me, which
>> blocks building
>> Krita on Windows with MSVC. While I'm working to setup a
>> mingw-build system on
>> Windows, I've moved the Vc code to a new branch:
>>
>> rempt-port-vc
>>
>> Where we should work to fix building without Vc. In the
>> meantime, I've reverted
>> everything in master, so CI and Windows users can at least
>> build again.
>>
>> Also note this bug report:
>>
>> https://bugs.kde.org/show_bug.cgi?id=361546
>>
>> "The brushes have become really slow in recent 3.0 alpha builds
>> compared to their 2.9 counterparts"
>>
>> On Fri, 8 Apr 2016, Friedrich W. H. Kossebau wrote:
>>
>> Hi Thorsten,
>>
>> seems this breaks non-Vc builds of Krita (to be seen on
>> CI, which still has Vc
>> 0.7.4 and thus tries to build without), e.g.
>>
>> https://build.kde.org/job/krita%20master%20kf5-qt5/
>> PLATFORM=Linux,compiler=gcc/63/
>>
>> Making Vc a hard dep would long-term be perhaps the best,
>> but for now Vc 1.0
>> is not that spread yet, so would put extra burdens to new
>> contributors (&
>> distributors).
>>
>> See below for one thing I found already.
>>
>> Am Donnerstag, 7. April 2016, 12:56:24 CEST schrieb
>> Thorsten Zachmann:
>> Git commit b68c1c7666510e268babc4cd87cd9d5ad34ff2d5
>> by Thorsten Zachmann.
>> Committed on 07/04/2016 at 12:54.
>> Pushed by zachmann into branch 'master'.
>>
>> Update krita to compile against Vc >= 1.0.0
>>
>>
>> <snip>
>>
>> diff --git
>> a/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h
>> b/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h index
>> 09677a6..2b10257 100644
>> ---
>> a/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h
>> +++
>> b/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h
>> @@ -35,6 +35,7 @@
>> #pragma warning ( disable : 4244 )
>> #pragma warning ( disable : 4800 )
>> #endif
>> +#include <Vc/global.h>
>> #include <Vc/Vc>
>> #include <Vc/support.h>
>> #if defined _MSC_VER
>> @@ -44,11 +45,9 @@
>> #else /* HAVE_VC */
>>
>> namespace Vc {
>> - typedef enum {ScalarImpl} Implementation;
>> + typedef enum {ScalarImpl} CurrentImplementation;
>> }
>>
>>
>> There still is Vc::Implementation in the code, so should
>> this here be not a
>> change Implementation->CurrentImplementation, but rather
>> an addition of
>> CurrentImplementation?
>>
>> There is also Vc::CurrentImplementation::current() in the
>> general code, so the
>> typedef might not be the working solution.
>>
>> Cheers
>> Friedrich
>>
>>
>> --
>> Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org
>> _______________________________________________
>> Krita mailing list
>> kimageshop@kde.org
>> https://mail.kde.org/mailman/listinfo/kimageshop
>>
>>
>>
>>
>> --
>> Dmitry Kazakov
>>
>>
>
>
>
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
[Attachment #5 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hello,<br>
<br>
I compiled Krita with Ubuntu 14.04 until the Vc change, then I
wasn't able to build it anymore. I completely dropped the 14.04
system and installing 16.04 right now. Maybe it was my fault, but
this change was a big problem on my Linux too.<br>
<br>
Fazek<br>
<br>
2016-04-10 13:59 keltezéssel, Boudewijn Rempt írta:<br>
</div>
<blockquote
cite="mid:alpine.LNX.2.00.1604101357380.31514@calcifer.valdyas.org"
type="cite">On Sun, 10 Apr 2016, Dmitry Kazakov wrote:
<br>
<br>
<blockquote type="cite">Erm... I would really expect that the
version without Vc would go into a separate branch, not doing
any reverts in master. Now you made
<br>
all the people who already built Vc 1.2 rebuild Krita again and
waste about an hour of their time.
<br>
</blockquote>
<br>
Yes, I realize that. But:
<br>
<br>
* CI was broken too
<br>
* Windows builds from master were impossible
<br>
* Raghukamath reported a big performance issue
<br>
<br>
All together, that was enough for me to decide that we need to
work on these issues in a branch and make master stable again.
<br>
<br>
Boudewijn
<br>
<br>
<br>
<blockquote type="cite">
<br>
On Sat, Apr 9, 2016 at 1:39 PM, Boudewijn Rempt
<a class="moz-txt-link-rfc2396E" \
href="mailto:boud@valdyas.org"><boud@valdyas.org></a> wrote: <br>
Making the build work without Vc was too tricky for me,
which blocks building
<br>
Krita on Windows with MSVC. While I'm working to setup a
mingw-build system on
<br>
Windows, I've moved the Vc code to a new branch:
<br>
<br>
rempt-port-vc
<br>
<br>
Where we should work to fix building without Vc. In the
meantime, I've reverted
<br>
everything in master, so CI and Windows users can at least
build again.
<br>
<br>
Also note this bug report:
<br>
<br>
<a class="moz-txt-link-freetext" \
href="https://bugs.kde.org/show_bug.cgi?id=361546">https://bugs.kde.org/show_bug.cgi?id=361546</a>
<br>
<br>
"The brushes have become really slow in recent 3.0 alpha
builds compared to their 2.9 counterparts"
<br>
<br>
On Fri, 8 Apr 2016, Friedrich W. H. Kossebau wrote:
<br>
<br>
Hi Thorsten,
<br>
<br>
seems this breaks non-Vc builds of Krita (to be seen
on CI, which still has Vc
<br>
0.7.4 and thus tries to build without), e.g.
<br>
<br>
<a class="moz-txt-link-freetext" \
href="https://build.kde.org/job/krita%20master%20kf5-qt5/">https://build.kde.org/job/krita%20master%20kf5-qt5/</a>
<br>
PLATFORM=Linux,compiler=gcc/63/
<br>
<br>
Making Vc a hard dep would long-term be perhaps the
best, but for now Vc 1.0
<br>
is not that spread yet, so would put extra burdens
to new contributors (&
<br>
distributors).
<br>
<br>
See below for one thing I found already.
<br>
<br>
Am Donnerstag, 7. April 2016, 12:56:24 CEST schrieb
Thorsten Zachmann:
<br>
Git commit
b68c1c7666510e268babc4cd87cd9d5ad34ff2d5 by Thorsten Zachmann.
<br>
Committed on 07/04/2016 at 12:54.
<br>
Pushed by zachmann into branch 'master'.
<br>
<br>
Update krita to compile against Vc >= 1.0.0
<br>
<br>
<br>
<snip>
<br>
<br>
diff --git
a/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h
<br>
b/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h index
<br>
09677a6..2b10257 100644
<br>
---
a/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h
<br>
+++
b/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h
<br>
@@ -35,6 +35,7 @@
<br>
#pragma warning ( disable : 4244 )
<br>
#pragma warning ( disable : 4800 )
<br>
#endif
<br>
+#include <Vc/global.h>
<br>
#include <Vc/Vc>
<br>
#include <Vc/support.h>
<br>
#if defined _MSC_VER
<br>
@@ -44,11 +45,9 @@
<br>
#else /* HAVE_VC */
<br>
<br>
namespace Vc {
<br>
- typedef enum {ScalarImpl} Implementation;
<br>
+ typedef enum {ScalarImpl}
CurrentImplementation;
<br>
}
<br>
<br>
<br>
There still is Vc::Implementation in the code, so
should this here be not a
<br>
change Implementation->CurrentImplementation, but
rather an addition of
<br>
CurrentImplementation?
<br>
<br>
There is also Vc::CurrentImplementation::current()
in the general code, so the
<br>
typedef might not be the working solution.
<br>
<br>
Cheers
<br>
Friedrich
<br>
<br>
<br>
--
<br>
Boudewijn Rempt | <a class="moz-txt-link-freetext" \
href="http://www.krita.org">http://www.krita.org</a>, <a \
class="moz-txt-link-freetext" \
href="http://www.valdyas.org">http://www.valdyas.org</a> <br>
_______________________________________________
<br>
Krita mailing list
<br>
<a class="moz-txt-link-abbreviated" \
href="mailto:kimageshop@kde.org">kimageshop@kde.org</a> <br>
<a class="moz-txt-link-freetext" \
href="https://mail.kde.org/mailman/listinfo/kimageshop">https://mail.kde.org/mailman/listinfo/kimageshop</a>
<br>
<br>
<br>
<br>
<br>
--
<br>
Dmitry Kazakov
<br>
<br>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Krita mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:kimageshop@kde.org">kimageshop@kde.org</a> <a \
class="moz-txt-link-freetext" \
href="https://mail.kde.org/mailman/listinfo/kimageshop">https://mail.kde.org/mailman/listinfo/kimageshop</a>
</pre>
</blockquote>
<br>
</body>
</html>
[Attachment #6 (text/plain)]
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic