Done.

http= s://quickgit.kde.org/?p=3Dkrita.git&a=3Dcommit&h=3D71c7b04ee73912df= c42892f2a48cb5d170ee1d12

2015-10-18 16:12 GMT+02:00 Boudewijn Rempt <boud@valdya= s.org>:

= Hi Juan,

That really is awesome detective work. I think the best option would be to = both have the peek() inside the kra/ora code and discuss whether changing k= archive makes sense on frameworks-devel.

Boudewijn

--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org

On Sat, 17 Oct 2015, Juan Palacios wrote:

Another solution is to not close the device inside the close method of KArc= hive (when the device is not owned).

=C2=A0=C2=A0=C2=A0 if (d->dev && d->dev !=3D d->saveFile) = {
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 d->dev->close();
=C2=A0=C2=A0=C2=A0 }

should be:

=C2=A0=C2=A0=C2=A0 if (d->deviceOwned && d->dev && d-= >dev !=3D d->saveFile) {
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 d->dev->close();
=C2=A0=C2=A0=C2=A0 }

Keep in mind that i dodn't test this approach and i don't know if t= his is correct nor the implications that this change could have to other ap= plications.

More ideas?

2015-10-17 19:18 GMT+02:00 Juan Palacios <jpalaciosdev@gmail.com>:
=C2=A0 =C2=A0 =C2=A0 I have been having some problems with missing icons on= all kde apps and the message QIODevice::seek (QBuffer): The device is not = open on the
=C2=A0 =C2=A0 =C2=A0 terminal. (This bug report seems to be related with th= is issue: https://bugs.kde.org/show_bug.cgi?id=3D352891= )

=C2=A0 =C2=A0 =C2=A0 I found that this bug is caused by the QImageIOPlugin = to support kra and ora formats (located on inst/lib64/plugins/).

=C2=A0 =C2=A0 =C2=A0 KZip is used to read the contents of the file through = the device on canRead(QIODevice *device) method. The problem is that KZip c= hanges the
=C2=A0 =C2=A0 =C2=A0 state of the device (closes it on his destructor). QIm= ageIOPlugin::capabilities documentation specifies that the device state sho= uld not be
=C2=A0 =C2=A0 =C2=A0 changed.

=C2=A0 =C2=A0 =C2=A0 There are two ways to solve this problem:
=C2=A0 =C2=A0 =C2=A0 The first one reopens the device at the end of capabil= ities method, but this can change the device state (read/write positions ..= .).

=C2=A0 =C2=A0 =C2=A0 Example for OraPlugin::capabilities(QIODevice *device,= const QByteArray &format) const

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 ...

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 const QIODevice::OpenMode mode =3D = device->openMode();

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 Capabilities cap;
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 if (device->isReadable() &&a= mp; OraHandler::canRead(device)) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cap |=3D Ca= nRead;
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 if (!device->isOpen())
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 device->= open(mode);

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 ...

=C2=A0 =C2=A0 =C2=A0 The other one is prone to future breaks if the kra or = ora internals are changed in some way, but it will not change the device st= ate. Consists
=C2=A0 =C2=A0 =C2=A0 in use device->peek method and extract the first 57= or 54 bytes (kra or ora), to obtain the "application/x-krita" an= d "image/openraster"
=C2=A0 =C2=A0 =C2=A0 directly.

=C2=A0 =C2=A0 =C2=A0 Example:
=C2=A0 =C2=A0 =C2=A0 bool OraHandler::canRead(QIODevice *device)
=C2=A0 =C2=A0 =C2=A0 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 if (!device) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 qWarning(&q= uot;KraHandler::canRead() called with no device");
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return fals= e;
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 char buff[54];
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 if (device->peek(buff, sizeof(bu= ff)) =3D=3D sizeof(buff))
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return qstr= cmp(buff + 0x26, "image/openraster") =3D=3D 0;

=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 return false;
=C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 I already tested both fixes and seems to solve the pro= blem.
=C2=A0 =C2=A0 =C2=A0 Thoughts on this?

_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop=