[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [calligra/calligra/2.9] /: [FEATURE] Lightness curve for per-channel filter
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2015-05-31 9:52:13
Message-ID: alpine.LNX.2.00.1505311146490.14850 () calcifer ! valdyas ! org
[Download RAW message or body]

On Sat, 30 May 2015, Dmitry Kazakov wrote:

> Git commit 45d4e30d35c9e027021b1a6ff585c9687cf1de83 by Dmitry Kazakov.
> Committed on 30/05/2015 at 22:04.
> Pushed by dkazakov into branch 'calligra/2.9'.
> 
> [FEATURE] Lightness curve for per-channel filter
> 
> Now the curves filter can do everything:
> 
> 1) Correct colors directly by editing RGB curves
> 2) Correct 'Lightness' using a special curve. Please
> not that this is not a 'RGB' curve like in Photoshop,
> it is a real Lightness curve from Lab color space.

Er... We already have a "real lightness curve from Lab color space" in 
Krita. That is exactly what the brightness-contrast curve is: it is a 
curve that is applied to the L channel of Lab.


> 3) Edit a curve for alpha
> 
> BUG:324332
> Ref T352
> 
> M  +13   -0    krita/image/kis_cubic_curve.cpp
> M  +2    -0    krita/image/kis_cubic_curve.h
> M  +17   -0    krita/image/tests/kis_cubic_curve_test.cpp
> M  +1    -0    krita/image/tests/kis_cubic_curve_test.h
> M  +1    -0    krita/plugins/filters/colorsfilters/CMakeLists.txt
> M  +156  -121  krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp
> M  +7    -1    krita/plugins/filters/colorsfilters/kis_perchannel_filter.h
> A  +62   -0    krita/plugins/filters/colorsfilters/virtual_channel_info.cpp     \
> [License: GPL (v2+)] C  +25   -21   \
> krita/plugins/filters/colorsfilters/virtual_channel_info.h [from: \
> krita/image/tests/kis_cubic_curve_test.h - 053% similarity]

What does this class do? There's no apidox.

> M  +1    -0    libs/pigment/CMakeLists.txt
> A  +62   -0    libs/pigment/KoCompositeColorTransformation.cpp     [License: GPL \
> (v2+)] A  +48   -0    libs/pigment/KoCompositeColorTransformation.h     [License: \
> GPL (v2+)]

What does this class do? There's no apidox.

Boudewijn

_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]