[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: auto levels in krita
From:       Alex Demko <ademko () gmail ! com>
Date:       2015-01-28 5:04:02
Message-ID: CALDftFriTzhra2L9-cz89H7_6n+f3aSfX=VMV0pWcuFOzM3ptg () mail ! gmail ! com
[Download RAW message or body]

Thanks!

I put my next change, a proposed fix for

Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

in the review board

https://git.reviewboard.kde.org/r/122284/



On Mon, Jan 26, 2015 at 3:58 AM, Boudewijn Rempt <boud@valdyas.org> wrote:
> Nice work! You even fixed the coding style by adding the m_ prefix (though I guess \
> it's not needed here: 
> -        // Update the histogram
> +        // Update the m_histogram
> )
> 
> The two usual places for patches are as attachments to a bug in bugs.kde.org or on \
> git.reviewboard.kde.org, but I'll just build and check and push your patches today. \
>  
> On Sunday 25 January 2015 Jan 14:47:16 Alex Demko wrote:
> > I added a small "auto levels" feature to krita, much like the feature
> > in the gimp. I noticed gimp by default presents the R/G/B histograms,
> > but by default krita works on the L one. I'm not a color guy, so I'm
> > not sure if this makes a big difference. It seems to work nicely,
> > though.
> > 
> > If the team is interested, the patches (1 for the feature, 1 to
> > QScopePointer a loose pointer) are here:
> > 
> > https://demko.ca/~ademko/kritalevels/
> > 
> > Feed back is appreciated. I tried to match style as much as possible.
> > If you 'd prefer I upload my git branch to github (or somewhere else),
> > I can do that.
> > 
> > Thanks
> > _______________________________________________
> > Krita mailing list
> > kimageshop@kde.org
> > https://mail.kde.org/mailman/listinfo/kimageshop
> 
> --
> Boudewijn Rempt
> http://www.valdyas.org, http://www.krita.org
> 
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]