[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: The resource bundle and resource md5 sums.
From: Wolthera <griffinvalley () gmail ! com>
Date: 2014-12-23 19:06:53
Message-ID: CAN80MtFhXhNH2fE=m+Zwa=rPZ6L3do-C_0-ZKaEBZ=hUTpSCCg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Okay, so this is pushed.
http://commits.kde.org/calligra/a56da8b3c3ddc868e937f5fbf39c271d0d98d2f5
Also, to fix a different bug where the preset docker would get confused
about which preset was the one you needed, the new or the old, I put in a
check to have resources not be added if they have the same name as an
existing resource.
This does not use MD5sum, because the resource dockers don't identify with
MD5sums either, but it's easily changed to check for MD5sum instead of name
when that time comes.
On Tue, Dec 23, 2014 at 6:02 PM, Wolthera <griffinvalley@gmail.com> wrote:
> Sorry, it doesn't install all bundles, it only installs activated bundles,
> so only the activated bundles take up start-up time :)
>
> I'll start implementing this then.
>
> On Tue, Dec 23, 2014 at 5:50 PM, Boudewijn Rempt <boud@valdyas.org> wrote:
>
>> On Tue, 23 Dec 2014, Wolthera wrote:
>>
>> So, right now, the resource bundle uses md5 sums to figure out which
>>> preset is part of it. However,
>>> these md5sums, which are stored in the manifest.xml are bogus.
>>>
>>
>> Hm... But they are the only way to figure out whether two resources are
>> the same. If the md5sums don't work, we've got a bigger problem!
>>
>> Right now, the actual details have gone quite fuzzy in my mind, and I'm
>> trying to focus on fixing the shortcuts/menu mess, so it's kind of hard to
>> figure out what's up.
>>
>> I do not know why they are bogus, but I am hoping to implement a bit of
>>> functionality that is half
>>> work-around and half kinda necessary anyway:
>>>
>>> First, Krita always installs all bundles upon start-up.
>>>
>>
>> That's actually something that needs fixing then -- because one of the
>> nice things of the bundles is that blacklisted/uninstalled bundles
>> shouldn't take memory or startup time.
>>
>> > I suggest we us this chance for the bundle
>>
>>> to collect all the md5sums of the resources it installs.
>>>
>>> Then, we get it to check it against all the manifest md5sums, when these
>>> are mismatched, we tell the
>>> user "Ah, it seems that these brushes have mismatching md5sums with the
>>> bundle's manifest. They may
>>> have gotten corrupted udring download:
>>> <list of brushes>"
>>>
>>> That way, the user actually can see the use of these weird numbery
>>> things.
>>>
>>> Then, when Krita deinstalls a bundle, it'll use the md5sums of what it
>>> knows it installed instead of
>>> the list in the manifest.
>>>
>>
>> We can do that, yes.
>>
>>
>>> Does this sound like a plan? We can then later figure out why the
>>> manifest md5sums are nonsense.
>>>
>>> --
>>> Wolthera
>>>
>>>
>>> _______________________________________________
>> Krita mailing list
>> kimageshop@kde.org
>> https://mail.kde.org/mailman/listinfo/kimageshop
>>
>
>
>
> --
> Wolthera
>
--
Wolthera
[Attachment #5 (text/html)]
<div dir="ltr"><div><div>Okay, so this is pushed.<br><a \
href="http://commits.kde.org/calligra/a56da8b3c3ddc868e937f5fbf39c271d0d98d2f5">http:/ \
/commits.kde.org/calligra/a56da8b3c3ddc868e937f5fbf39c271d0d98d2f5</a><br><br></div>Also, \
to fix a different bug where the preset docker would get confused about which preset \
was the one you needed, the new or the old, I put in a check to have resources not be \
added if they have the same name as an existing resource.<br><br></div>This does not \
use MD5sum, because the resource dockers don't identify with MD5sums either, but \
it's easily changed to check for MD5sum instead of name when that time \
comes.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 23, \
2014 at 6:02 PM, Wolthera <span dir="ltr"><<a \
href="mailto:griffinvalley@gmail.com" \
target="_blank">griffinvalley@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>Sorry, it doesn't install all \
bundles, it only installs activated bundles, so only the activated bundles take up \
start-up time :)<br><br></div>I'll start implementing this then.<br></div><div \
class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Tue, Dec 23, \
2014 at 5:50 PM, Boudewijn Rempt <span dir="ltr"><<a \
href="mailto:boud@valdyas.org" target="_blank">boud@valdyas.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span>On Tue, 23 Dec 2014, Wolthera wrote:<br> <br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> So, right now, the resource bundle uses md5 sums to figure \
out which preset is part of it. However,<br> these md5sums, which are stored in the \
manifest.xml are bogus.<br> </blockquote>
<br></span>
Hm... But they are the only way to figure out whether two resources are the same. If \
the md5sums don't work, we've got a bigger problem!<br> <br>
Right now, the actual details have gone quite fuzzy in my mind, and I'm trying to \
focus on fixing the shortcuts/menu mess, so it's kind of hard to figure out \
what's up.<span><br> <br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> I do not know why they are bogus, but I am hoping to \
implement a bit of functionality that is half<br> work-around and half kinda \
necessary anyway:<br> <br>
First, Krita always installs all bundles upon start-up.<br>
</blockquote>
<br></span>
That's actually something that needs fixing then -- because one of the nice \
things of the bundles is that blacklisted/uninstalled bundles shouldn't take \
memory or startup time.<span><br> <br>
> I suggest we us this chance for the bundle<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> to collect all the md5sums of the resources it installs.<br>
<br>
Then, we get it to check it against all the manifest md5sums, when these are \
mismatched, we tell the<br> user "Ah, it seems that these brushes have \
mismatching md5sums with the bundle's manifest. They may<br> have gotten \
corrupted udring download:<br> <list of brushes>"<br>
<br>
That way, the user actually can see the use of these weird numbery things.<br>
<br>
Then, when Krita deinstalls a bundle, it'll use the md5sums of what it knows it \
installed instead of<br> the list in the manifest.<br>
</blockquote>
<br></span>
We can do that, yes.<span><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
Does this sound like a plan? We can then later figure out why the manifest md5sums \
are nonsense.<br> <br>
--<br>
Wolthera<br>
<br>
<br>
</blockquote></span>
______________________________<u></u>_________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/<u></u>listinfo/kimageshop</a><br> \
</blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font \
color="#888888">-- <br><div>Wolthera</div> </font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div \
class="gmail_signature">Wolthera</div> </div>
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic