[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Re: Krita shared pointers usage
From:       Stefano Bonicatti <smjert () gmail ! com>
Date:       2014-12-15 13:19:35
Message-ID: CAGMAV48+=5MV2G2ia=j7jqeFOAOL9Z-4Krqtp4uY3zbXZ09CLA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> Where did that happen?

I added a comment some days ago to a bug report ->
https://bugs.kde.org/show_bug.cgi?id=337648#c5 .
Together with other things leaked, there was the rootLayer of the image.

> What I think would be a good thing to do is this: either for a single
> instance of a shared pointer (like the image's root layer) or for a single
> type of shared pointer, create a proposal with a patch to improve that
> single issue. Then we can check what happens and see how to fix the rest
> of Krita.

Yes i agree, forgot to say that i wasn't proposing to change everything now
(because that's obviously insane), but that they should be used less from
"now" on and that the parts that contains them should be slowly
fixed/cleaned, as you proposed.

[Attachment #5 (text/html)]

<div dir="ltr"><span style="font-size:10px">&gt; Where did that happen?</span><br \
style="font-size:10px"><div><span style="font-size:10px"><br></span></div><div><span \
style="font-size:10px">I added a comment some days ago to a bug report -&gt;  \
</span><font size="1"><a \
href="https://bugs.kde.org/show_bug.cgi?id=337648#c5">https://bugs.kde.org/show_bug.cgi?id=337648#c5</a> \
.</font></div><div><font size="1">Together with other things leaked, there was the \
rootLayer of the image.</font></div><div><font size="1"><br></font></div><div><span \
style="font-size:10px">&gt; What I think would be a good thing to do is this: either \
for a single</span><br style="font-size:10px"><span style="font-size:10px">&gt; \
instance of a shared pointer (like the image&#39;s root layer) or for a \
single</span><br style="font-size:10px"><span style="font-size:10px">&gt; type of \
shared pointer, create a proposal with a patch to improve that</span><br \
style="font-size:10px"><span style="font-size:10px">&gt; single issue. Then we can \
check what happens and see how to fix the rest</span><br style="font-size:10px"><span \
style="font-size:10px">&gt; of Krita.</span><font \
size="1"><br></font></div><div><span \
style="font-size:10px"><br></span></div><div><span style="font-size:10px">Yes i \
agree, forgot to say that i wasn&#39;t proposing to change everything now (because \
that&#39;s obviously insane), but that they should be used less from &quot;now&quot; \
on and that the parts that contains them should be slowly fixed/cleaned, as you \
proposed.  </span></div></div>



_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]