[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: MVC branch initial impressions and list of bugs.
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2014-10-17 0:40:26
Message-ID: CAAmsBfnou-FuWeObbF5X00YrgV_3Y0Gi-CQJ0M8yk0zHkpgOMQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Oct 16, 2014 at 7:06 PM, Wolthera <griffinvalley@gmail.com> wrote:

> Okay, so the Multi view control branch for Krita has finally entered
> testing stage, so I build it and started poking at it:
>
> Some notes for those who want to try it out themselves:
>
> * had to empty build for this.
> * had to empty trash afterwards.
>
> otherwise it just creates build errors.
>
> Now for the notes:
>
> * settings became confused in this build.
> ** ctrl+z doesn't work.
> ** confirm(by pressing enter), in transform and crop doesn't work
> ** Nor does the pop-up palette, rotate mode, or zoom.
> ** Top-bar misses actions.
> *** Undo freehand brush-stroke is only availeble in file<calligra>, not in
> brushes and stuff<krita>
> *** The same for zooming, and brush smoothening(!)
> ** Activate linetool is greyed out in preferences.
> * many actions are missing from the view-menu(expected?)(grid-actions are
> missing)
> * Actions misordered in File as well...
>

Not sure what happened there, it used to work.


> * Slowdowns on focussing windows/canvases.(gnome thinks it froze and is
> asking me whether I would like to kill Krita)
> ** closing preferences and going to canvas will cause slowdown.
> ** going between multiple documents will cause slowdown.
>

KisImageView::setParentView call resetDisplayProfile which is quite slow.
It should be checked if that even needed there.


> ** Going to an outside program and coming back in will also cause slowdown.
> * Assistants are broken and cause crash.
>

Assistants are still missing from mvc.


> * General slowdown on selection and geometric tools. (It tags notably
> between confirm and actual drawing, feels similar to the
> layer-gui-update-lag that slangkamp had to fix kisview for, maybe it's
> trying too hard to figure out on which canvas it's trying to paint?)(only
> happens in tabbed mode).
>

Doesn't happen here.


> * New view works great!
> ** Undo is shared between views wel!
> ** Color is randomly not remembered between switching
> focus-canvas.(returns to black...)
>

Can't reproduce that.


> * Tiled view works okay.
> ** However, it gets a little strange when trying to resize the canvas
> windows. (asif it's trying to snap constantly)
> ** Painting between canvases works great, adjusting the navigation between
> canvases doesn't(lag)
> ** Overview docker works great between canvasses, (but again, super-lag on
> switching focus canvas)
>

There is a small delay due to the update time, but appart from that it's
not unusally slow here. Might be fixed with the latest master merge.


> * Closing a view is super-slow.
> * When using subwindows, when Krita is closed down, and then restarted,
> and multiple documents are opened, Krita does not recognise that they
> should be subwindowed. Nor does it draw tabs. If you select Tiled-view in
> the windows submenu, it subwindows them correctly.
>

That only works if changed in the settings. I think tiled view should not
be available in the menu if the application is in tabbed mode.


> * Odd bug: Select a tool(example circle) in one view, paint with it on
> another. Then go to the other view, paint again, undo. Go back to first
> view, paint, notice that it only uses the freehand brush. No switching of
> tools will actually happen in the first view, only in the second.
> (sometimes it works the other way around, it seems, the common thread is
> that if a tool has been changed in one cnavas, the other canvas doesn't
> understand this, and it results in the other canvas not being able to
> change tools anymore)
> ** As well, the tool options with this bug will be garbled, as if the
> tool-options where not switched out, but just painted on top of each other.
>

Which options? Can happen when the ui file isn't merge correctly.


> * Wrap-around mode works well!
> * Perspective grid tool works... but it's sublines are not drawn.
>

Fixed.


> * undoing a selection caused a crash...(not reproducable)
> * crash on attempting to show grid!(reproducable, probly missing action)
>

Grid actions are not set up as the manager expects to have an imageview.
Manager and decoration need to be split. We also can't store the setting
into a KisConfig as that breaks when you want to have different image with
different grids.


> * crash when using the right-mouseclick(for me assigned to color-picker)
> while in a terminal that hovers above a Krita window.
>

Fixed, I think.


> * Terminal complains about color slider docker being assigned a new layout
> constantly(proly my fault)
>

Also in master.


> * Terminal complains about this: krita(2941)
> KWidgetItemDelegateEventListener::eventFilter: User of KWidgetItemDelegate
> should not delete widgets created by createItemWidgets! (repeated like, 20
> times each time you start up Krita)
> * Terminal complains about paintop presets: krita(3626)
> KisPaintopBox::setCurrentPaintop: current paintop  "Basic_tip_default"  was
> not set, not supported by colorspace
>
> tl;dr: The problems can be subdivided into several catagories:
> 1) Hotkeys, settings and missing actions.
> 2) Confusion between canvasses.
> 3) Slowdown.
> 4) Miscelaneous.
>
> I will sent the crash-reports in seperate mails after.
>
> --
> Wolthera
>
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Oct 16, 2014 \
at 7:06 PM, Wolthera <span dir="ltr">&lt;<a href="mailto:griffinvalley@gmail.com" \
target="_blank">griffinvalley@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div><div><div>Okay, so the Multi view control branch for Krita has finally \
entered testing stage, so I build it and started poking at it:<br><br></div>Some \
notes for those who want to try it out themselves:<br><br>* had to empty build for \
this.<br>* had to empty trash afterwards.<br><br></div>otherwise it just creates \
build errors.<br><br></div>Now for the notes:<br><br>* settings became confused in \
this build.<br>** ctrl+z doesn&#39;t work.<br>** confirm(by pressing enter), in \
transform and crop doesn&#39;t work <br>** Nor does the pop-up palette, rotate mode, \
or zoom.<br>** Top-bar misses actions.<br>*** Undo freehand brush-stroke is only \
availeble in file&lt;calligra&gt;, not in brushes and stuff&lt;krita&gt;<br>*** The \
same for zooming, and brush smoothening(!)<br>** Activate linetool is greyed out in \
preferences.<br>* many actions are missing from the view-menu(expected?)(grid-actions \
are missing)<br>* Actions misordered in File as \
well...<br></div></blockquote><div><br></div><div>Not sure what happened there, it \
used to work.</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px \
0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Slowdowns on focussing windows/canvases.(gnome thinks it froze and is \
asking me whether I would like to kill Krita)<br>** closing preferences and going to \
canvas will cause slowdown.<br>** going between multiple documents will cause \
slowdown.<br></div></blockquote><div><br></div><div>KisImageView::setParentView call  \
resetDisplayProfile which is quite slow. It should be checked if that even needed \
there.<br></div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px \
0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">** Going to an outside program and coming back in will also cause \
slowdown.<br>* Assistants are broken and cause \
crash.<br></div></blockquote><div><br></div><div>Assistants are still missing from \
mvc.</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* General slowdown on selection and geometric tools. (It tags notably \
between confirm and actual drawing, feels similar to the layer-gui-update-lag that \
slangkamp had to fix kisview for, maybe it&#39;s trying too hard to figure out on \
which canvas it&#39;s trying to paint?)(only happens in tabbed \
mode).<br></div></blockquote><div><br></div><div>Doesn&#39;t happen here.</div><div>  \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* New view works great!<br>** Undo is shared between views wel!<br>** Color \
is randomly not remembered between switching focus-canvas.(returns to \
black...)<br></div></blockquote><div><br></div><div>Can&#39;t reproduce \
that.</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Tiled view works okay.<br>** However, it gets a little strange when \
trying to resize the canvas windows. (asif it&#39;s trying to snap constantly)<br>** \
Painting between canvases works great, adjusting the navigation between canvases \
doesn&#39;t(lag)<br>** Overview docker works great between canvasses, (but again, \
super-lag on switching focus canvas)<br></div></blockquote><div><br></div><div>There \
is a small delay due to the update time, but appart from that it&#39;s not unusally \
slow here. Might be fixed with the latest master merge.</div><div>  </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Closing a view is super-slow.<br>* When using subwindows, when Krita is \
closed down, and then restarted, and multiple documents are opened, Krita does not \
recognise that they should be subwindowed. Nor does it draw tabs. If you select \
Tiled-view in the windows submenu, it subwindows them \
correctly.<br></div></blockquote><div><br></div><div>That only works if changed in \
the settings. I think tiled view should not be available in the menu if the \
application is in tabbed mode.</div><div>  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Odd bug: Select a tool(example circle) in one view, paint with it on \
another. Then go to the other view, paint again, undo. Go back to first view, paint, \
notice that it only uses the freehand brush. No switching of tools will actually \
happen in the first view, only in the second. (sometimes it works the other way \
around, it seems, the common thread is that if a tool has been changed in one cnavas, \
the other canvas doesn&#39;t understand this, and it results in the other canvas not \
being able to change tools anymore)<br>** As well, the tool options with this bug \
will be garbled, as if the tool-options where not switched out, but just painted on \
top of each other.<br></div></blockquote><div><br></div><div>Which options? Can \
happen when the ui file isn&#39;t merge correctly.</div><div>  </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Wrap-around mode works well!<br>* Perspective grid tool works... but \
it&#39;s sublines are not \
drawn.<br></div></blockquote><div><br></div><div>Fixed.</div><div>  </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* undoing a selection caused a crash...(not reproducable)<br>* crash on \
attempting to show grid!(reproducable, probly missing \
action)<br></div></blockquote><div><br></div><div>Grid actions are not set up as the \
manager expects to have an imageview. Manager and decoration need to be split. We \
also can&#39;t store the setting into a KisConfig as that breaks when you want to \
have different image with different grids.</div><div>  </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* crash when using the right-mouseclick(for me assigned to color-picker) \
while in a terminal that hovers above a Krita \
window.<br></div></blockquote><div><br></div><div>Fixed, I think.</div><div>  \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Terminal complains about color slider docker being assigned a new layout \
constantly(proly my fault)<br></div></blockquote><div><br></div><div>Also in \
master.</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">* Terminal complains about this: krita(2941) \
KWidgetItemDelegateEventListener::eventFilter: User of KWidgetItemDelegate should not \
delete widgets created by createItemWidgets! (repeated like, 20 times each time you \
start up Krita)<br>* Terminal complains about paintop presets: krita(3626) \
KisPaintopBox::setCurrentPaintop: current paintop   &quot;Basic_tip_default&quot;   \
was not set, not supported by colorspace \
<br><div><div><div><div><br></div><div>tl;dr: The problems can be subdivided into \
several catagories:<br></div><div>1) Hotkeys, settings and missing \
actions.<br></div><div>2) Confusion between canvasses.<br></div><div>3) Slowdown.<br \
clear="all"></div><div><div><div>4) Miscelaneous.<br></div><div><br></div><div>I will \
sent the crash-reports in seperate mails after.<span class=""><font \
color="#888888"><br></font></span></div><span class=""><font \
color="#888888"><div><br>-- <br>Wolthera \
</div></font></span></div></div></div></div></div></div> \
<br>_______________________________________________<br> Krita mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br></div></div>



_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic