[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Junior Job (Bug 245658)
From: Koushik S <skoushik333 () gmail ! com>
Date: 2014-03-14 19:30:32
Message-ID: CAEwJJ=Tjb+S-PjE5DkTTjj7tEn7Aumn1a14EJcC=pmj0+_JGzQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I seem to be having a difficulty in getting the second ellipse on the popup
palette. I've added a second mask to the popup palette, but it seems that
the enclosing rectangle covers the current interface and I couldn't really
figure out a way to globally change it.
I fiddled around with the presetIndex method which changes the layout of
the palette, but then almost all of the layout parameters have to be
changed accordingly.
I wanted to know if there was any other way to accomplish this, or if this
is the only option. Either way, I would like to finish this.
On Sun, Mar 9, 2014 at 9:49 PM, Sven Langkamp <sven.langkamp@gmail.com>wrote:
> On Sun, Mar 9, 2014 at 3:40 PM, Koushik S <skoushik333@gmail.com> wrote:
>
>> That's a very cool idea, and I've implemented it upto a certain point. It
>> currently displays only one color (the FG color), although adding a
>> previous color would not be that difficult, I think. Here's the current
>> implementation : http://i.imgur.com/nlnIiaT.png
>>
>
> The I think that's a bit too color intense. I think maybe it should be
> just in one corner like this: http://i.imgur.com/USGDml1.png (color area
> should be even smaller). The other corner could be used to a configuration
> button (also much smaller).
>
>
>> Also, you can notice that the color actually takes up the space occupied
>> by the brush images. I couldn't figure out how to 'extend' the boundary of
>> the popup palette to accommodate it. Can I get some pointers regarding that?
>>
>
> You need to increase the size of the widget and then adjust the relative
> sizes of everything inside to the new layout.
>
>
>>
>> On Thu, Mar 6, 2014 at 11:08 PM, David Revoy <davidrevoy@gmail.com>wrote:
>>
>>> >> I want to know how the element should be displayed. I got a
>>> suggestion that it must be a square area at one of the corners.
>>> Cool ! Here is an open idea proposition to debate about the color
>>> position : http://i.imgur.com/BQWrFDM.png
>>>
>>> _____________________
>>> http://www.davidrevoy.com
>>>
>>>
>>> On Thu, Mar 6, 2014 at 6:27 PM, Koushik S <skoushik333@gmail.com> wrote:
>>>
>>>> Hi again,
>>>>
>>>> So I was messing around with the popup_palette file, and I seem to
>>>> have reached upto a point where it can display the foreground color in
>>>> whatever path is defined. I want to know how the element should be
>>>> displayed. I got a suggestion that it must be a square area at one of the
>>>> corners. However, I seem to be having a difficulty in implementing that.
>>>> Here's a (failed) attempt to display the selected color in the popup
>>>> palette: http://picpaste.com/9sZLF49e.png
>>>>
>>>>
>>>>
>>>> On Tue, Feb 25, 2014 at 10:02 AM, Dmitry Kazakov <dimula73@gmail.com>wrote:
>>>>
>>>>> Hi, Koushik!
>>>>>
>>>>> If I understood you right, you already have a
>>>>> KisColorSelectorComponent in the pop-up box in the instance of
>>>>> 'm_triangleColorSelector', so yes, you can access this method.
>>>>>
>>>>> Talking about preview of the currently selected color, you might want
>>>>> to look at the code in KisColorPreviewPopup class, which is in
>>>>> kis_color_selector_base.cpp file. Probably, you would be able to share the
>>>>> code between those two classes.
>>>>>
>>>>>
>>>>>
>>>>> On Mon, Feb 24, 2014 at 10:07 PM, Koushik S <skoushik333@gmail.com>wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> I was working on and off on Bug 245658 (JJ: Ability to see
>>>>>> currently selected color in a pop-up palette), and went through the code in
>>>>>> kis_popup_palette (thanks to boud for directing me to it!).
>>>>>>
>>>>>> I tried to add code to get the required feature, but to no avail.
>>>>>> In fact, the code actually replicated the already built-in feature of
>>>>>> displaying the recently used color.
>>>>>>
>>>>>> I examined the code which updates the color selector, and have a
>>>>>> vague idea of solving this. Would it be correct if I initialize a
>>>>>> KisColorSelectorComponent and use it's currentColor() method to get the
>>>>>> currently selected color? If not, could someone point me in the right
>>>>>> direction. Thanks.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> regards,
>>>>>> Koushik. S
>>>>>>
>>>>>> _______________________________________________
>>>>>> Krita mailing list
>>>>>> kimageshop@kde.org
>>>>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dmitry Kazakov
>>>>>
>>>>> _______________________________________________
>>>>> Krita mailing list
>>>>> kimageshop@kde.org
>>>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> regards,
>>>> Koushik. S
>>>>
>>>> _______________________________________________
>>>> Krita mailing list
>>>> kimageshop@kde.org
>>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Krita mailing list
>>> kimageshop@kde.org
>>> https://mail.kde.org/mailman/listinfo/kimageshop
>>>
>>>
>>
>>
>> --
>> regards,
>> Koushik. S
>>
>> _______________________________________________
>> Krita mailing list
>> kimageshop@kde.org
>> https://mail.kde.org/mailman/listinfo/kimageshop
>>
>>
>
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>
--
regards,
Koushik. S
[Attachment #5 (text/html)]
<div dir="ltr">I seem to be having a difficulty in getting the second ellipse on the \
popup palette. I've added a second mask to the popup palette, but it seems that \
the enclosing rectangle covers the current interface and I couldn't really figure \
out a way to globally change it. <div> <br></div><div>I fiddled around with the \
presetIndex method which changes the layout of the palette, but then almost all of \
the layout parameters have to be changed accordingly. </div><div><br></div><div>I \
wanted to know if there was any other way to accomplish this, or if this is the only \
option. Either way, I would like to finish this.</div> </div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 9, 2014 at 9:49 PM, \
Sven Langkamp <span dir="ltr"><<a href="mailto:sven.langkamp@gmail.com" \
target="_blank">sven.langkamp@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div \
class="gmail_quote"><div class="">On Sun, Mar 9, 2014 at 3:40 PM, Koushik S <span \
dir="ltr"><<a href="mailto:skoushik333@gmail.com" \
target="_blank">skoushik333@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">That's a very cool idea, and I've implemented it upto a certain \
point. It currently displays only one color (the FG color), although adding a \
previous color would not be that difficult, I think. Here's the current \
implementation : <a href="http://i.imgur.com/nlnIiaT.png" \
target="_blank">http://i.imgur.com/nlnIiaT.png</a></div>
</blockquote><div><br></div></div><div>The I think that's a bit too color \
intense. I think maybe it should be just in one corner like this: <a \
href="http://i.imgur.com/USGDml1.png" \
target="_blank">http://i.imgur.com/USGDml1.png</a> (color area should be even \
smaller). The other corner could be used to a configuration button (also much \
smaller).</div> <div class="">
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">Also, you can notice that the color actually takes up the space occupied by \
the brush images. I couldn't figure out how to 'extend' the boundary of \
the popup palette to accommodate it. Can I get some pointers regarding that?</div>
</blockquote><div><br></div></div><div>You need to increase the size of the widget \
and then adjust the relative sizes of everything inside to the new \
layout.</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 6, 2014 \
at 11:08 PM, David Revoy <span dir="ltr"><<a href="mailto:davidrevoy@gmail.com" \
target="_blank">davidrevoy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div><div>>> I want to know how the element should be displayed. I \
got a suggestion that it must be a square area at one of the corners.<br>
</div>Cool ! Here is an open idea proposition to debate about the color position : <a \
href="http://i.imgur.com/BQWrFDM.png" \
target="_blank">http://i.imgur.com/BQWrFDM.png</a><br></div></div><div \
class="gmail_extra"><br clear="all">
<div><font size="1"><span \
style="color:rgb(192,192,192)">_____________________</span><br><a \
href="http://www.davidrevoy.com" \
target="_blank">http://www.davidrevoy.com</a></font><br>
</div><div><div>
<br><br><div class="gmail_quote">On Thu, Mar 6, 2014 at 6:27 PM, Koushik S <span \
dir="ltr"><<a href="mailto:skoushik333@gmail.com" \
target="_blank">skoushik333@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div>Hi again,<br><br></div> So I was messing around with the \
popup_palette file, and I seem to have reached upto a point where it can display the \
foreground color in whatever path is defined. I want to know how the element should \
be displayed. I got a suggestion that it must be a square area at one of the corners. \
However, I seem to be having a difficulty in implementing that. Here's a (failed) \
attempt to display the selected color in the popup palette: <a \
href="http://picpaste.com/9sZLF49e.png" \
target="_blank">http://picpaste.com/9sZLF49e.png</a><br>
<br></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Tue, \
Feb 25, 2014 at 10:02 AM, Dmitry Kazakov <span dir="ltr"><<a \
href="mailto:dimula73@gmail.com" target="_blank">dimula73@gmail.com</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div><div>Hi, Koushik!<br><br></div>If I understood you right, you already \
have a KisColorSelectorComponent in the pop-up box in the instance of \
'm_triangleColorSelector', so yes, you can access this method.<br>
<br></div>Talking about preview of the currently selected color, you might want to \
look at the code in KisColorPreviewPopup class, which is in \
kis_color_selector_base.cpp file. Probably, you would be able to share the code \
between those two classes.<br>
<br></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Mon, \
Feb 24, 2014 at 10:07 PM, Koushik S <span dir="ltr"><<a \
href="mailto:skoushik333@gmail.com" \
target="_blank">skoushik333@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div><div \
dir="ltr">Hello,<div><br></div>
<div> I was working on and off on Bug 245658 (JJ: Ability to see currently \
selected color in a pop-up palette), and went through the code in kis_popup_palette \
(thanks to boud for directing me to it!). </div>
<div><br></div><div> I tried to add code to get the required feature, but to no \
avail. In fact, the code actually replicated the already built-in feature of \
displaying the recently used color.</div><div><br></div><div>
I examined the code which updates the color selector, and have a vague idea of \
solving this. Would it be correct if I initialize a KisColorSelectorComponent and use \
it's currentColor() method to get the currently selected color? If not, could \
someone point me in the right direction. Thanks.</div>
<span><font color="#888888">
<div><br><div><br></div>-- <br><div dir="ltr"><div>regards,</div>Koushik. S</div>
</div></font></span></div>
<br></div></div>_______________________________________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><br>-- \
<br>Dmitry Kazakov </font></span></div>
<br>_______________________________________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br><br clear="all"><br>-- <br></div></div><div \
dir="ltr"><div>regards,</div>Koushik. S</div> </div>
<br>_______________________________________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br></div></div></div> \
<br>_______________________________________________<br> Krita mailing list<br>
<a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br><br clear="all"><br>-- <br><div \
dir="ltr"><div>regards,</div>Koushik. S</div> </div>
</div></div><br>_______________________________________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div></div></div><br></div></div> \
<br>_______________________________________________<br> Krita mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
dir="ltr"><div>regards,</div>Koushik. S</div> </div>
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic