[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [calligra] krita/ui: Fixing Minor bugs
From:       Lukast dev <lukast.dev () gmail ! com>
Date:       2013-08-11 9:59:39
Message-ID: CAKdU0rMMeLKtO7wkjyPkA-tQEAtntX7rhyOWmJGMTmHmY7tqEQ () mail ! gmail ! com
[Download RAW message or body]

Hi Sahil,

what kind of minor bugs?
Can you refer to bug report number?

Lukas

2013/8/10 Sahil Nagpal <nagpal.sahil01@gmail.com>:
> Git commit 3f33bcd07c9e1c3477fd1ad8e50f3bbb8e0b9a45 by Sahil Nagpal.
> Committed on 10/08/2013 at 20:04.
> Pushed by sahilnagpal into branch 'master'.
> 
> Fixing Minor bugs
> 
> M  +1    -2    krita/ui/canvas/kis_canvas_decoration.cc
> M  +1    -1    krita/ui/canvas/kis_canvas_decoration.h
> M  +0    -5    krita/ui/kis_selection_decoration.cc
> M  +0    -1    krita/ui/kis_selection_decoration.h
> M  +2    -1    krita/ui/widgets/kis_multi_bool_filter_widget.cc
> 
> http://commits.kde.org/calligra/3f33bcd07c9e1c3477fd1ad8e50f3bbb8e0b9a45
> 
> diff --git a/krita/ui/canvas/kis_canvas_decoration.cc \
> b/krita/ui/canvas/kis_canvas_decoration.cc index 60dca81..ecc4fcd 100644
> --- a/krita/ui/canvas/kis_canvas_decoration.cc
> +++ b/krita/ui/canvas/kis_canvas_decoration.cc
> @@ -63,8 +63,7 @@ bool KisCanvasDecoration::visible() const
> 
> void KisCanvasDecoration::toggleVisibility()
> {
> -    d->visible = !d->visible;
> -    d->view->canvas()->update();
> +    setVisible(!visible());
> }
> 
> void KisCanvasDecoration::paint(QPainter& gc, const QRectF& updateArea, const \
>                 KisCoordinatesConverter *converter, KisCanvas2 *canvas = 0)
> diff --git a/krita/ui/canvas/kis_canvas_decoration.h \
> b/krita/ui/canvas/kis_canvas_decoration.h index 0f3e402..842d729 100644
> --- a/krita/ui/canvas/kis_canvas_decoration.h
> +++ b/krita/ui/canvas/kis_canvas_decoration.h
> @@ -63,7 +63,7 @@ public slots:
> /**
> * If decoration is visible, hide it, if not show it.
> */
> -    virtual void toggleVisibility();
> +    void toggleVisibility();
> protected:
> virtual void drawDecoration(QPainter& gc, const QRectF& updateArea, const \
> KisCoordinatesConverter *converter,KisCanvas2* canvas) = 0; 
> diff --git a/krita/ui/kis_selection_decoration.cc \
> b/krita/ui/kis_selection_decoration.cc index 7a927b7..7134948 100644
> --- a/krita/ui/kis_selection_decoration.cc
> +++ b/krita/ui/kis_selection_decoration.cc
> @@ -156,11 +156,6 @@ void KisSelectionDecoration::drawDecoration(QPainter& gc, \
> const QRectF& updateRe gc.restore();
> }
> 
> -void KisSelectionDecoration::toggleVisibility()
> -{
> -    setVisible(!visible());
> -}
> -
> void KisSelectionDecoration::setVisible(bool v)
> {
> KisCanvasDecoration::setVisible(v);
> diff --git a/krita/ui/kis_selection_decoration.h \
> b/krita/ui/kis_selection_decoration.h index 2b7ccf2..3e3deca 100644
> --- a/krita/ui/kis_selection_decoration.h
> +++ b/krita/ui/kis_selection_decoration.h
> @@ -39,7 +39,6 @@ public:
> 
> void setMode(Mode mode);
> void setVisible(bool v);
> -    void toggleVisibility();
> 
> protected:
> void drawDecoration(QPainter& gc, const QRectF& updateRect, const \
>                 KisCoordinatesConverter *converter,KisCanvas2* canvas);
> diff --git a/krita/ui/widgets/kis_multi_bool_filter_widget.cc \
> b/krita/ui/widgets/kis_multi_bool_filter_widget.cc index dba640f..0e3a4fb 100644
> --- a/krita/ui/widgets/kis_multi_bool_filter_widget.cc
> +++ b/krita/ui/widgets/kis_multi_bool_filter_widget.cc
> @@ -63,7 +63,8 @@ void KisMultiBoolFilterWidget::setConfiguration(const \
> KisPropertiesConfiguration {
> if (!config) return;
> for (int i = 0; i < nbValues(); ++i) {
> -        m_boolWidgets[i]->setChecked(true);
> +        double val = config->getBool(m_boolWidgets[i]->objectName(), true);
> +        m_boolWidgets[i]->setChecked(val);
> }
> }
> 
> 
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]