'Re: New round of testing for the OpenGL + bended lines fix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-kimageshop
Subject: Re: New round of testing for the OpenGL + bended lines fix
From: Timothée_Giet <animtim () gmail ! com>
Date: 2013-01-21 12:30:26
Message-ID: CAPgMCOCtL_XWWoLGoxcQU3F9LZCUwcEbi632cqZtHK-fHY2ngg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hi Dmitry,

First, before to update, I tried to reproduce David's regression, couldn't
reproduce: here decorations are showing right.

After update:
0-lines seem the same as before (bend a little only on really too fast or
too big strokes)
1-no more warning message at all
2-Lasso tool outline still ok.
3-pop-up palette works.
(4-not on your branch, so...)

If I can test it on some different hardware I'll report results.

2013/1/21 Dmitry Kazakov <dimula73@gmail.com>

> Hi!
>
> Yesterday David found a regression caused by the disabling of Double
> Buffer [0]. It looks like the outlines and decorations of the tools start
> flickering and/or being rendered wrongly when double buffering is disabled.
>
> I have just pushed a patch that fixes this bug: it makes disabling the
> Double Buffer be the last resort. So now we entirely rely on that openGL
> extensions juggling code. Could you, please, test this code on various
> hardware so that I could backport it into calligra/2.6 as well? (yes,
> calligra/2.6 currently has this regression)
>
> What you should pay attention to when testing:
>
> 0) The lines must not be bended.
> 1) Does it show any warning messages when creating an image?
> 2) Is the outline of the Lasso Tool painted right? (doesn't flicker)
> 3) Pop-up palette must work.
> 4) (when on my branch only) The preview of the transform tool must be
> rendered right.
>
> The fix is present in both branches: master and
> krita-fixed-transform-kazakov, so you can test on any. The latter one is in
> a state of yesterday's master + a cool new transform tool :)
>
>
> [0] - https://bugs.kde.org/show_bug.cgi?id=313568
>
> --
> Dmitry Kazakov
> _______________________________________________
> kimageshop mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>

[Attachment #5 (text/html)]

Hi Dmitry, First, before to update, I tried to reproduce David&#39;s \
regression, couldn&#39;t reproduce: here decorations are showing \
right. After update: 0-lines seem the same as before (bend a \
little only on really too fast or too big strokes) 1-no more warning \
message at all 2-Lasso tool outline still ok. 3-pop-up palette \
works. (4-not on your branch, so...) If I can test it on some \
different hardware I&#39;ll report results. <div \
class="gmail_quote"> 2013/1/21 Dmitry Kazakov &lt;<a \
href="mailto:dimula73@gmail.com" \
target="_blank">dimula73@gmail.com</a>&gt; <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi! Yesterday David found a regression \
caused by the disabling of Double Buffer [0]. It looks like the outlines \
and decorations of the tools start flickering and/or being rendered wrongly \
when double buffering is disabled.

I have just pushed a patch that fixes this bug: it makes disabling the \
Double Buffer be the last resort. So now we entirely rely on that openGL \
extensions juggling code. Could you, please, test this code on various \
hardware so that I could backport it into calligra/2.6 as well? (yes, \
calligra/2.6 currently has this regression)

What you should pay attention to when testing: 0) The lines must \
not be bended. 1) Does it show any warning messages when creating an \
image? 2) Is the outline of the Lasso Tool painted right? (doesn&#39;t \
flicker)

3) Pop-up palette must work. 4) (when on my branch only) The preview of \
the transform tool must be rendered right. The fix is present in \
both branches: master and krita-fixed-transform-kazakov, so you can test on \
any. The latter one is in a state of yesterday&#39;s master + a cool new \
transform tool :)

<br><br>[0] - <a href="https://bugs.kde.org/show_bug.cgi?id=313568" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=313568</a><span \
class="HOEnZb"><font color="#888888"><br clear="all"><br>-- <br>Dmitry \
Kazakov </font></span><br>_______________________________________________<br>
 kimageshop mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br>

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

[prev in list] [next in list] [prev in thread] [next in thread] 