[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Vc branch ready for testing
From: Sven Langkamp <sven.langkamp () gmail ! com>
Date: 2012-09-27 15:17:01
Message-ID: CAAmsBf=7MnQ7rewSca583y0L3Mrss2kwqOGCccq9K1OomS7y6g () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Thu, Sep 27, 2012 at 5:42 AM, Dmitry Kazakov <dimula73@gmail.com> wrote:
> Hi!
>
> And there is a major bug: the Vc cmake script doesn't add itself into
> INCLUDE_DIRECTORIES. This makes compilation fail when Vc is not installed
> into system root (which is the common case for developers).
>
> [ 55%] Building CXX object
> krita/image/CMakeFiles/kritaimage.dir/kis_circle_mask_generator.cpp.o
>
> /home/devel/kde-src/calligra/krita/image/kis_circle_mask_generator.cpp:25:17:
> fatal error: Vc/Vc: No such file or
> directory
> compilation terminated.
> make[2]: ***
> [krita/image/CMakeFiles/kritaimage.dir/kis_circle_mask_generator.cpp.o]
> Error 1
> make[2]: *** Waiting for unfinished jobs....
> [ 55%] Built target textshape
> make[1]: *** [krita/image/CMakeFiles/kritaimage.dir/all] Error 2
> make: *** [all] Error 2
>
>
I have added Vc_INCLUDE_DIR to the include directories now. Can you check
if it works now?
>
>
> On Thu, Sep 27, 2012 at 7:39 AM, Dmitry Kazakov <dimula73@gmail.com>wrote:
>
>> Hi!
>>
>> I've not finished compiling it yet, but at the stage of configuration
>> there are two really minor bugs:
>>
>> 1) When there is no Vc in the system, cmake gives a warning (but succeeds
>> with configuration):
>>
>> CMake Warning at
>> /usr/share/kde4/apps/cmake/modules/MacroOptionalFindPackage.cmake:32
>> (find_package):
>> Could not find module FindVc.cmake or a configuration file for package
>> Vc.
>>
>> Adjust CMAKE_MODULE_PATH to find FindVc.cmake or set Vc_DIR to the
>> directory containing a CMake configuration file for Vc. The file will
>> have
>> one of the following names:
>>
>> VcConfig.cmake
>> vc-config.cmake
>>
>>
>> Call Stack (most recent call first):
>> krita/CMakeLists.txt:15 (macro_optional_find_package)
>>
>> 2) In both of the cases, when Vc is present in the system or not, Vc is
>> not listed in libraries which are printed by cmake in the end of
>> configuration.
>>
>>
>>
>> On Thu, Sep 27, 2012 at 7:31 AM, Dmitry Kazakov <dimula73@gmail.com>wrote:
>>
>>>
>>>
>>>>> Yes, I got that too when I tried the same thing. I didn't investigate
>>>>> too closely back then, but I can have a look.
>>>>
>>>>
>>>> Problem is solved now. The Vc branch should now be ready for merge.
>>>> Anyone want to give it a final round of testing?
>>>>
>>>
>>> I can do it =)
>>>
>>> --
>>> Dmitry Kazakov
>>>
>>
>>
>>
>> --
>> Dmitry Kazakov
>>
>
>
>
> --
> Dmitry Kazakov
>
> _______________________________________________
> kimageshop mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>
[Attachment #5 (text/html)]
<div class="gmail_quote">On Thu, Sep 27, 2012 at 5:42 AM, Dmitry Kazakov <span \
dir="ltr"><<a href="mailto:dimula73@gmail.com" \
target="_blank">dimula73@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi!<br><br>And there is a major bug: the Vc cmake script \
doesn't add itself into INCLUDE_DIRECTORIES. This makes compilation fail when Vc \
is not installed into system root (which is the common case for developers).<br>
<br>[ 55%] Building CXX object \
krita/image/CMakeFiles/kritaimage.dir/kis_circle_mask_generator.cpp.o \
<br>/home/devel/kde-src/calligra/krita/image/kis_circle_mask_generator.cpp:25:17: \
fatal error: Vc/Vc: No such file or directory \
<br>
compilation terminated.<br>make[2]: *** \
[krita/image/CMakeFiles/kritaimage.dir/kis_circle_mask_generator.cpp.o] Error \
1<br>make[2]: *** Waiting for unfinished jobs....<br>[ 55%] Built target \
textshape<br>make[1]: *** [krita/image/CMakeFiles/kritaimage.dir/all] Error 2<br>
make: *** [all] Error 2<div class="HOEnZb"><div \
class="h5"><br></div></div></blockquote><div><br></div><div>I have added \
Vc_INCLUDE_DIR to the include directories now. Can you check if it works \
now?</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 \
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div \
class="h5"><br><br><div class="gmail_quote">On Thu, Sep 27, 2012 at 7:39 AM, Dmitry \
Kazakov <span dir="ltr"><<a href="mailto:dimula73@gmail.com" \
target="_blank">dimula73@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi!<br><br>I've not finished compiling it yet, but at the \
stage of configuration there are two really minor bugs:<br>
<br>1) When there is no Vc in the system, cmake gives a warning (but succeeds with \
configuration):<br> <br>CMake Warning at \
/usr/share/kde4/apps/cmake/modules/MacroOptionalFindPackage.cmake:32 \
(find_package):<br> Could not find module FindVc.cmake or a configuration file for \
package Vc.<br><br> Adjust CMAKE_MODULE_PATH to find FindVc.cmake or set Vc_DIR to \
the<br>
directory containing a CMake configuration file for Vc. The file will have<br> \
one of the following names:<br><br> VcConfig.cmake<br> \
vc-config.cmake<div><br><br>Call Stack (most recent call first):<br> </div> \
krita/CMakeLists.txt:15 (macro_optional_find_package)<br> <br>2) In both of the \
cases, when Vc is present in the system or not, Vc is not listed in libraries which \
are printed by cmake in the end of configuration.<div><div><br><br><br><div \
class="gmail_quote"> On Thu, Sep 27, 2012 at 7:31 AM, Dmitry Kazakov <span \
dir="ltr"><<a href="mailto:dimula73@gmail.com" \
target="_blank">dimula73@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><br><div class="gmail_quote"><div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><br>
</div>Yes, I got that too when I tried the same thing. I didn't investigate too \
closely back then, but I can have a look.</blockquote></div><br></div><div>Problem is \
solved now. The Vc branch should now be ready for merge. Anyone want to give it a \
final round of testing?</div>
</blockquote></div><div><br>I can do it =)<span><font color="#888888"><br> \
<br></font></span></div></div><span><font color="#888888">-- <br>Dmitry Kazakov<br> \
</font></span></blockquote></div><br><br clear="all"><br></div></div><span><font \
color="#888888">-- <br>Dmitry Kazakov<br> </font></span></blockquote></div><br><br \
clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br>Dmitry \
Kazakov<br> </font></span><br>_______________________________________________<br>
kimageshop mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br>
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic