[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: some code warnings
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-12-05 12:20:49
Message-ID: 201112051320.49399.boud () valdyas ! org
[Download RAW message or body]

On Monday 05 December 2011 Dec, Jaime wrote:
> * There is a return in the middle of void
> KisFilterBumpmap::process(KisPaintDeviceSP device, const QRect&
> applyRect, const KisFilterConfiguration* config, KoUpdater*
> progressUpdater) const (line 225)
> in krita/plugins/filters/bumpmap/bumpmap.cpp

Oh my... Good catch -- and that return has been there for three years now! Which \
makes it unsurprising that if I remove the return, the bumpmap filter turns out to be \
completely broken :-(


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]