[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Problems with oldRawData
From:       JL VT <pentalis () gmail ! com>
Date:       2011-10-01 13:42:58
Message-ID: CAMTAOSt-BRP2=86-T_ODqb-S_d7F6Dzt=HV9ZWc5tx8OfEAQdw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Our iterators have oldRawData() and rawData() available for access. Only the
latter seems to be useful.

The Unsharp Mask filter is broken, it generates 1x64 lines instead of 1x1
pixels as a result of the operation. I found that changing the iterator from
const to non-const, and using rawData() instead of oldRawData() in every
situation, makes it behave as expected.
This is not the first time I've seen oldRawData() giving off useless
information, instead of the expected Old Raw Data of a pixel.

I think whatever mechanism fills oldRawData's information is broken
somewhere. Is there a Unit Test to keep this behavior in check?.

I don't want to submit the patch fixing the Unsharp Mask filter since using
rawData() instead of oldRawData() is just a duct-tape solution, the problem
is that oldRawData() isn't giving the right data back.



Any thought?.

[Attachment #5 (text/html)]

Our iterators have oldRawData() and rawData() available for access. Only th=
e latter seems to be useful.<div><br></div><div>The Unsharp Mask filter is =
broken, it generates 1x64 lines instead of 1x1 pixels as a result of the op=
eration. I found that changing the iterator from const to non-const, and us=
ing rawData() instead of oldRawData() in every situation, makes it behave a=
s expected.</div>
<div>This is not the first time I&#39;ve seen oldRawData() giving off usele=
ss information, instead of the expected Old Raw Data of a pixel.</div><div>=
<br></div><div>I think whatever mechanism fills oldRawData&#39;s informatio=
n is broken somewhere. Is there a Unit Test to keep this behavior in check?=
.</div>
<div><br></div><div>I don&#39;t want to submit the patch fixing the Unsharp=
 Mask filter since using rawData() instead of oldRawData() is just a duct-t=
ape solution, the problem is that oldRawData() isn&#39;t giving the right d=
ata back.</div>
<div><br></div><div><br></div><div><br></div><div>Any thought?.</div>


_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]