[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Beta 2 tagging delay
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-09-29 13:46:59
Message-ID: 201109291546.59996.boud () valdyas ! org
[Download RAW message or body]

On Thursday 29 September 2011 Sep, Boudewijn Rempt wrote:
> On Thursday 29 September 2011 Sep, Cyrille Berger Skott wrote:
> > On Thursday 29 September 2011, Boudewijn Rempt wrote:
> > > > So any objection to the revert of
> > > > ef3277a2bd7dd0b9454114d1562b633dff47c86e ?
> > > 
> > > Yes, I prefer to delay the tagging of the beta release, instead of causing
> > > a mess for the krita developers by reverting a huge merge.
> > 
> > There are only two commits after that from krita developers, so they can be 
> > moved to the "krita-bugfixhere" branch, with all krita development. Also I was 
> > under the impression that everybody agreed that a commit that breaks, should 
> > either be fixed ASAP or reverted ? 
> 
> Yes, we want to fix it ASAP. That's what I'm telling you. 


Okay, I might have a temporary patch, but it needs to be tested... I think it's the \
progress updater that is causing the hangs, but it's just a hunch and I just tried to \
paint for five minutes and didn't get a hang. I have no theory about why or what.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl


["no_progress_no_hangs.diff" (text/x-patch)]

diff --git a/krita/ui/kis_view2.cpp b/krita/ui/kis_view2.cpp
index 3341695..bc3ae93 100644
--- a/krita/ui/kis_view2.cpp
+++ b/krita/ui/kis_view2.cpp
@@ -759,7 +759,7 @@ void KisView2::connectCurrentImage()
          * progress updaters. The latter way should be depracated in favour
          * of displaying the status of the global strokes queue
          */
-        image()->compositeProgressProxy()->addProxy(m_d->statusBar->progress()->progressProxy());
+        //image()->compositeProgressProxy()->addProxy(m_d->statusBar->progress()->progressProxy());
     }
 
     m_d->canvas->connectCurrentImage();


_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]