[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: https://bugs.kde.org/show_bug.cgi?id=281761 -- scaling between
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-09-18 18:30:54
Message-ID: 201109182030.54897.boud () valdyas ! org
[Download RAW message or body]

On Sunday 18 September 2011 Sep, Sven Langkamp wrote:
> On Sun, Sep 18, 2011 at 7:54 PM, Silvio Heinrich <plassy@web.de> wrote:
> 
> > On 09/18/2011 03:06 PM, Boudewijn Rempt wrote:
> >
> >> hi,
> >>
> >> I'm stuck with this bug... Could someone with adequate templating foo
> >> please check my patch and help me out a bit? I get a crash now if I follow
> >> the instructions in the bug report exactly.
> >>
> >
> > Ok I got it. Now it seems to work.
> > Now just one part is missing.
> > We need to test if the destination colorspace uses floating point channels
> > so that the second part of the "else" part is executed.
> >
> 
> Theoretically there could be a colorspace that has integer and floating
> point channel. At the moment all color space have same type and size though.
> 
> For the check you could use KoChannelInfo.

That's why I only patched KoColorspaceAbstract -- that's guaranteed to be homogenous.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]