[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Grayscale Selections
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2011-07-16 22:39:46
Message-ID: CAAmsBfkk9wBqH0G7KtD1qHd6ce3PhtS-xLAUNuzSzp3nppfk4g () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Jul 16, 2011 at 10:17 PM, Sven Langkamp <sven.langkamp@gmail.com>wrote:

> On Sat, Jul 16, 2011 at 10:06 PM, Cyrille Berger Skott <
> cberger@cberger.net> wrote:
>
>> On Saturday 16 July 2011, Sven Langkamp wrote:
>> > Try that but I didn't get it to work, see attachment. Is that what you
>> > suggested?
>> > gray2.diff
>> yup. And it did not work most likely because we don't use that overload of
>> bitblt but the one with all the parameters in the function (and right now,
>> we
>> have an API flaw in KoColorSpace, only one of the bitBlt should be virtual
>> and
>> the other should simply call the virtual one).
>>
>
> Hmm I somehow saved the wrong diff and reverted the other code :/
>
> I also tried the params method. That was called by the result was exactly
> the same as when I didn't overwrite anything.
>

Correction. Right code after all. I checked and at least the method is
called, but does nothing.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sat, Jul 16, 2011 at 10:17 PM, Sven Langkamp <span \
dir="ltr">&lt;<a href="mailto:sven.langkamp@gmail.com">sven.langkamp@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="gmail_quote"><div class="im">On Sat, Jul \
16, 2011 at 10:06 PM, Cyrille Berger Skott <span dir="ltr">&lt;<a \
href="mailto:cberger@cberger.net" target="_blank">cberger@cberger.net</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">

<div>On Saturday 16 July 2011, Sven Langkamp wrote:<br>
&gt; Try that but I didn&#39;t get it to work, see attachment. Is that what you<br>
&gt; suggested?<br>
</div>&gt; gray2.diff<br>
yup. And it did not work most likely because we don&#39;t use that overload of<br>
bitblt but the one with all the parameters in the function (and right now, we<br>
have an API flaw in KoColorSpace, only one of the bitBlt should be virtual and<br>
the other should simply call the virtual one).<br></blockquote></div><div><br>Hmm I \
somehow saved the wrong diff and reverted the other code :/<br><br>I also tried the \
params method. That was called by the result was exactly the same as when I \
didn&#39;t overwrite anything. <br>

</div></div>
</blockquote></div><br>Correction. Right code after all. I checked and at least the \
method is called, but does nothing.<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]