From kde-kimageshop  Fri Jul 01 08:27:32 2011
From: Cyrille Berger Skott <cberger () cberger ! net>
Date: Fri, 01 Jul 2011 08:27:32 +0000
To: kde-kimageshop
Subject: Re: [calligra] krita/plugins/filters/blur: parenthesis to know the
Message-Id: <201107011027.32515.cberger () cberger ! net>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=130950888324687

Hi,

It does break the test "krita-image-KisAsyncMergerTest" (see
http://my.cdash.org/viewTest.php?onlydelta&buildid=204196). But I am guessing 
KisAsyncMergerTest was relying on the buggy behaviour of kis_blur_filter 
configuration. Dmitry, can you have a look to adjust the configuration of the 
blur filter used in that test ? Or if the test image need to be regenerated.

On Thursday 30 June 2011, Jaime Torres wrote:
> Git commit 3cea838598fd6f148e0cef78a43e28fa7e73f44d by Jaime Torres.
> Committed on 30/06/2011 at 20:12.
> Pushed by jtamate into branch 'master'.
> 
> parenthesis to know the exact meaning of an expresion with ? operator.
> 
> part of review 101803
> 
> M  +1    -1    krita/plugins/filters/blur/kis_blur_filter.cpp
> 
> http://commits.kde.org/calligra/3cea838598fd6f148e0cef78a43e28fa7e73f44d
> 
> diff --git a/krita/plugins/filters/blur/kis_blur_filter.cpp
> b/krita/plugins/filters/blur/kis_blur_filter.cpp index 3a45bc2..9e3833b
> 100644
> --- a/krita/plugins/filters/blur/kis_blur_filter.cpp
> +++ b/krita/plugins/filters/blur/kis_blur_filter.cpp
> @@ -78,7 +78,7 @@ void KisBlurFilter::process(KisPaintDeviceSP device,
>      uint halfHeight = (config->getProperty("halfHeight", value)) ?
> value.toUInt() : 5; uint height = 2 * halfHeight + 1;
>      int rotate = (config->getProperty("rotate", value)) ? value.toInt() :
> 0; -    int strength = 100 - (config->getProperty("strength", value)) ?
> value.toUInt() : 0; +    int strength = 100 -
> (config->getProperty("strength", value) ? value.toUInt() : 0);
> 
>      int hFade = (halfWidth * strength) / 100;
>      int vFade = (halfHeight * strength) / 100;


-- 
Cyrille Berger Skott
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop