[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Did something break with the selection?
From:       Silvio Heinrich <plassy () web ! de>
Date:       2011-04-29 14:43:10
Message-ID: 4DBACE7E.3060304 () web ! de
[Download RAW message or body]

On 04/29/2011 03:11 PM, Cyrille Berger Skott wrote:
> I think we need to change line 83 of KoCompositeOpAlphaBase to
> srcAlpha = KoColorSpaceMaths<quint8, channels_type>::multiply(*mask, srcAlpha,
> opacity);
>
> And KoColorSpaceMaths::multiply(_T a, _Tdst b, _Tdst c) to:
>
> inline static _Tdst multiply(_T a, _Tdst b, _Tdst c) {
>      return (dst_compositetype(a)*b*c) /
> (dst_compositetype(KoColorSpaceMathsTraits<_Tdst>::unitValue) *
> KoColorSpaceMathsTraits<_T>::unitValue);
> }
>
> And it should fix it.
Whoo!! Thank you!
I think I would have spend a lifetime searching for this :D
I committed the fix.

Thx
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]