[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Bug fix for Bug 127571 - new feature: split the image
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-03-22 9:03:59
Message-ID: 201103221003.59709.boud () valdyas ! org
[Download RAW message or body]

On Monday 21 March 2011 Mar, srikanth tiyyagura wrote:
> Hi to all,
> 
> This is bug fix for Bug 127571 - new feature: split the image .
> I used the code of some other files and prepared this one. Check out
> once and correct me if there are any mistakes.
> 
> ImageSplit is a widget , which is used to split the image based on
> vertical split lines and also horizontal lines, which are provided by
> the user. These splitted images are saved without effecting the main
> image.

Cool stuff! Works like a charm and it looks pretty clean already. 

A couple of remarks:

* replace my copyright with your copyright and update the year. I know you started by \
copying files from another plugin, but that was just as a template. This is your \
                code!
* set a shortcut on the action, or create a new action to apply the saved split with \
                the keyboard only, without opening the dialog. Maciej will be very \
                glad withthat.
* use the original filename + N as name, not imagesplit_N.kra
* maybe ask the user for a filetype, like png or jpg
* the dialog needs another layout to show up correctly, here (because I use a large \
font size), part of the dialog is cut off.

Do you already have commit access or shall I commit this version so you can continue \
working on it?

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]