From kde-kimageshop  Mon Mar 21 08:05:03 2011
From: Valentin Cheillon <cheillonvalentin () gmail ! com>
Date: Mon, 21 Mar 2011 08:05:03 +0000
To: kde-kimageshop
Subject: Re: bug fix : 251622
Message-Id: <AANLkTikRh-YYyqYACDe3ZVtuLzsHTZUt_5iQmz8uZEwt () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=130069475010710
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--000e0cd23b84c5a307049ef99564"

--000e0cd23b84c5a307049ef99564
Content-Type: multipart/alternative; boundary=000e0cd23b84c5a2f6049ef99562

--000e0cd23b84c5a2f6049ef99562
Content-Type: text/plain; charset=ISO-8859-1

Hello,
My last fix was not screen resolution dependant ( I just got lucky when I
tested ), This one is resolution dependant but the centering is still not
perfect
because some dialogs expand dynamically just after I positionned them. Here
is a screen : http://img851.imageshack.us/i/filterdialogcenterwithw.png/
and the patch is enclosed. If you want it to be perfectly centered, I will
investigate further.
Thanks

2011/3/19 Valentin Cheillon <cheillonvalentin@gmail.com>

> Hi again,
> As Sven told me, there will be two different patches: one for the centering
> of the dialogs, the other for removing
> the margins inside the level filter dialog.
> This is the patch for the first one. The centering is not perfect because I
> don't understand all qt positioning mechanisms.
> But I guess the result is still correct.
>
> 2011/3/19 Sven Langkamp <sven.langkamp@gmail.com>
>
>> On Sat, Mar 19, 2011 at 3:10 PM, Valentin Cheillon <
>> cheillonvalentin@gmail.com> wrote:
>>
>>> Hello everyone,
>>>
>>> I tried to fix this bug  http://bugs.kde.org/251622.
>>> It was just about modifying properties with qtDesigner
>>> I Hope the patch fits your needs because it was just about qt layout
>>> management and I am not a pro on it.
>>> You can find the patch attached done with git diff.
>>>
>>
>> The patch only decreases the size of the widget, but the dialog is still
>> too big.
>> See http://i.imgur.com/Ydv5U.png
>>
>> _______________________________________________
>> kimageshop mailing list
>> kimageshop@kde.org
>> https://mail.kde.org/mailman/listinfo/kimageshop
>>
>>
>

--000e0cd23b84c5a2f6049ef99562
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hello,<br>My last fix was not screen resolution dependant ( I just got luck=
y when I tested ), This one is resolution dependant but the centering is st=
ill not perfect<br>because some dialogs expand dynamically just after I pos=
itionned them. Here is a screen : <a href=3D"http://img851.imageshack.us/i/=
filterdialogcenterwithw.png/">http://img851.imageshack.us/i/filterdialogcen=
terwithw.png/</a><br>
and the patch is enclosed. If you want it to be perfectly centered, I will =
investigate further.<br>Thanks<br><br><div class=3D"gmail_quote">2011/3/19 =
Valentin Cheillon <span dir=3D"ltr">&lt;<a href=3D"mailto:cheillonvalentin@=
gmail.com">cheillonvalentin@gmail.com</a>&gt;</span><br>
<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0.8ex; borde=
r-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi again,<br>As S=
ven told me, there will be two different patches: one for the centering of =
the dialogs, the other for removing<br>
the margins inside the level filter dialog.<br>This is the patch for the fi=
rst one. The centering is not perfect because I don&#39;t understand all qt=
 positioning mechanisms.<br>
But I guess the result is still correct.<br><br><div class=3D"gmail_quote">=
<div><div></div><div class=3D"h5">2011/3/19 Sven Langkamp <span dir=3D"ltr"=
>&lt;<a href=3D"mailto:sven.langkamp@gmail.com" target=3D"_blank">sven.lang=
kamp@gmail.com</a>&gt;</span><br>
</div></div><blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt =
0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div>=
<div></div><div class=3D"h5">
<div><div></div><div><div class=3D"gmail_quote">On Sat, Mar 19, 2011 at 3:1=
0 PM, Valentin Cheillon <span dir=3D"ltr">&lt;<a href=3D"mailto:cheillonval=
entin@gmail.com" target=3D"_blank">cheillonvalentin@gmail.com</a>&gt;</span=
> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0.8ex; borde=
r-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hello everyone,<br><br>I tried to fix this bug=A0 <a href=3D"http://bugs.kd=
e.org/251622" target=3D"_blank">http://bugs.kde.org/251622</a>.<br>It was j=
ust about modifying properties with qtDesigner<br>I Hope the patch fits you=
r needs because it was just about qt layout management and I am not a pro o=
n it.<br>



You can find the patch attached done with git diff.<br></blockquote></div><=
br></div></div>The patch only decreases the size of the widget, but the dia=
log is still too big.<br>See <a href=3D"http://i.imgur.com/Ydv5U.png" targe=
t=3D"_blank">http://i.imgur.com/Ydv5U.png</a><br>


<br></div></div>_______________________________________________<br>
kimageshop mailing list<br>
<a href=3D"mailto:kimageshop@kde.org" target=3D"_blank">kimageshop@kde.org<=
/a><br>
<a href=3D"https://mail.kde.org/mailman/listinfo/kimageshop" target=3D"_bla=
nk">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
<br></blockquote></div><br>
</blockquote></div><br>

--000e0cd23b84c5a2f6049ef99562--
--000e0cd23b84c5a307049ef99564
Content-Type: text/x-patch; charset=US-ASCII; name="centering_bug.patch"
Content-Disposition: attachment; filename="centering_bug.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_glj3y88b1

ZGlmZiAtLWdpdCBhL2tyaXRhL3VpL2tpc19maWx0ZXJfaGFuZGxlci5jYyBiL2tyaXRhL3VpL2tp
c19maWx0ZXJfaGFuZGxlci5jYwppbmRleCAyNzA1YjlkLi5jZTQ4MmM3IDEwMDY0NAotLS0gYS9r
cml0YS91aS9raXNfZmlsdGVyX2hhbmRsZXIuY2MKKysrIGIva3JpdGEvdWkva2lzX2ZpbHRlcl9o
YW5kbGVyLmNjCkBAIC0xMzEsNiArMTMxLDEyIEBAIHZvaWQgS2lzRmlsdGVySGFuZGxlcjo6c2hv
d0RpYWxvZygpCiAgICAgICAgICAgICAgICAgU0xPVChhcHBseShLaXNOb2RlU1AsIEtpc0ZpbHRl
ckNvbmZpZ3VyYXRpb24qKSkpOwogICAgICAgICBkaWFsb2ctPnNldFZpc2libGUodHJ1ZSk7CiAg
ICAgICAgIGRpYWxvZy0+c2V0QXR0cmlidXRlKFF0OjpXQV9EZWxldGVPbkNsb3NlKTsKKworICAg
ICAgICAvL3Bvc2l0aW9ubmluZyB0aGUgd2lkZ2V0IHRvIHRoZSBjZW50ZXIKKyAgICAgICAgaW50
IHg9bV9kLT52aWV3LT5nZW9tZXRyeSgpLngoKSttX2QtPnZpZXctPmdlb21ldHJ5KCkud2lkdGgo
KS8yLWRpYWxvZy0+d2lkdGgoKS8yOworICAgICAgICBpbnQgeT1tX2QtPnZpZXctPmdlb21ldHJ5
KCkueSgpK21fZC0+dmlldy0+Z2VvbWV0cnkoKS5oZWlnaHQoKS8yLWRpYWxvZy0+aGVpZ2h0KCkv
MjsKKyAgICAgICAgZGlhbG9nLT5zZXRHZW9tZXRyeSh4LHksZGlhbG9nLT53aWR0aCgpLGRpYWxv
Zy0+aGVpZ2h0KCkpOworCiAgICAgfSBlbHNlIHsKICAgICAgICAgYXBwbHkobV9kLT52aWV3LT5h
Y3RpdmVOb2RlKCksIG1fZC0+ZmlsdGVyLT5kZWZhdWx0Q29uZmlndXJhdGlvbihtX2QtPnZpZXct
PmFjdGl2ZU5vZGUoKS0+b3JpZ2luYWwoKSkpOwogICAgIH0K
--000e0cd23b84c5a307049ef99564
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

--000e0cd23b84c5a307049ef99564--