[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: A small change in Layer dock code for proper functioning of
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2011-03-20 8:22:44
Message-ID: AANLkTinYJeWOhqG1UO_mcvfAf7BGwEH4MO74Ud+cLPup () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Mar 20, 2011 at 10:55 AM, Boudewijn Rempt <> wrote:

> On Saturday 19 March 2011 Mar, srikanth tiyyagura wrote:
> > Hi to all,
> >
> >           This is the code for solving the deletion issue upto the
> > last layer in the layers dock.
> > Please review this and if any correct me
> >
> >   what I did is if the image layer reach the final Layer , then
> > disabling the delete button
>
> I think that's correct. I had a brief discussion about it on irc with
> Dmitry, but I do feel that it's bad usability to let the user create an
> entirely empty image file. There should be at least one layer. However, this
> patch isn't quite done yet: we need to make sure that the last layer staying
> up isn't a clone layer or a filter layer, I think.
>

This is ok for a Filter Layer to become the only layer in the stack. The
clone layer (i guess) should reincarnate into a usual paint layer after it's
source is deleted.

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Sun, Mar 20, 2011 at 10:55 AM, Boudewijn Rempt \
<span dir="ltr">&lt;&gt;</span> wrote:<br><blockquote class="gmail_quote" \
style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); \
padding-left: 1ex;"> <div><div></div><div class="h5">On Saturday 19 March 2011 Mar, \
srikanth tiyyagura wrote:<br> &gt; Hi to all,<br>
&gt;<br>
&gt;                This is the code for solving the deletion issue upto the<br>
&gt; last layer in the layers dock.<br>
&gt; Please review this and if any correct me<br>
&gt;<br>
&gt;    what I did is if the image layer reach the final Layer , then<br>
&gt; disabling the delete button<br>
<br>
</div></div>I think that&#39;s correct. I had a brief discussion about it on irc with \
Dmitry, but I do feel that it&#39;s bad usability to let the user create an entirely \
empty image file. There should be at least one layer. However, this patch isn&#39;t \
quite done yet: we need to make sure that the last layer staying up isn&#39;t a clone \
layer or a filter layer, I think.<font color="#888888"><br>

</font></blockquote></div><br>This is ok for a Filter Layer to become the only layer \
in the stack. The clone layer (i guess) should reincarnate into a usual paint layer \
                after it&#39;s source is deleted.<br clear="all"><br>
-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]