[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Patch: Many composite/blend modes mostly compatible to Adobe
From: Sven Langkamp <sven.langkamp () gmail ! com>
Date: 2011-02-06 22:57:36
Message-ID: AANLkTinSo8SemkLGSbd04Hs31GDfAo0UKXTrb-NiwiPF () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Sun, Feb 6, 2011 at 11:37 PM, Silvio Heinrich <plassy@web.de> wrote:
> On 02/06/2011 10:56 PM, Sven Langkamp wrote:
>
> What compiler version do you use?
>
> gcc 4.4.3
>
>
>> And can you please try to add this include to the top of the
>> libs/pigment/compositeops/KoCompositeOps.h header:
>>
>> #include "KoColorSpaceMaths.h"
>>
>> and compile again.
>>
>
> Doesn't work.
>
> Argg.. I hate when something like this happens :-/.
> I think we have to back-trace this then.
> It would be nice if you could erase the entire content of
> libs/pigment/compositeops/KoCompositeOps.h and try
> this two versions instead:
>
> #ifndef _KO_COMPOSITEOPS_H_
> #define _KO_COMPOSITEOPS_H_
>
> #include "KoColorSpace.h"
> #include "KoColorSpaceTraits.h"
> #include "KoCompositeOp.h"
> #include "compositeops/KoCompositeOpFunctions.h"
> #include "compositeops/KoCompositeOpGeneric.h"
>
> template<class Traits>
> void addStandardCompositeOps(KoColorSpace* cs)
> {
> cs->addCompositeOp(new KoCompositeOpGenericSC<Traits,
> &cfVividLight>(cs, COMPOSITE_VIVID_LIGHT, i18n("Vivid Light"),
> KoCompositeOp::categoryLight(), true));
> }
>
>
> // _KO_COMPOSITEOPS_H_
>
>
> and:
>
> #ifndef _KO_COMPOSITEOPS_H_
> #define _KO_COMPOSITEOPS_H_
>
> #include "KoColorSpace.h"
> #include "KoColorSpaceTraits.h"
> #include "KoCompositeOp.h"
> #include "compositeops/KoCompositeOpFunctions.h"
> #include "compositeops/KoCompositeOpGeneric.h"
>
> template<class Traits>
> void addStandardCompositeOps(KoColorSpace* cs)
> {
> typedef typename Traits::channels_type Arg;
> cs->addCompositeOp(new KoCompositeOpGenericSC< Traits,
> &cfVividLight<Arg> >(cs, COMPOSITE_VIVID_LIGHT, i18n("Vivid Light"),
> KoCompositeOp::categoryLight(), true));
> }
>
>
> // _KO_COMPOSITEOPS_H_
>
> If you get some compiling errors instead of linking errors I made some
> mistake :D but I hope it will compile.
> So, please try the two versions an tell me what errors you get :D
> I have gcc 4.4.5 but I can just hardly believe that 4.4.3 isn't able to
> compile this :/
>
>
>
In both cases I get:
CMakeFiles/pigmentcms.dir/colorspaces/KoLabColorSpace.o: In function
`unsigned short cfVividLight<unsigned short>(unsigned short, unsigned
short)':
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0x31):
undefined reference to `KoColorSpaceMathsTraits<unsigned short>::unitValue'
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0x3d):
undefined reference to `KoColorSpaceMathsTraits<unsigned short>::zeroValue'
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0xb3):
undefined reference to `KoColorSpaceMathsTraits<unsigned short>::zeroValue'
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0xbf):
undefined reference to `KoColorSpaceMathsTraits<unsigned short>::unitValue'
CMakeFiles/pigmentcms.dir/colorspaces/KoRgbU8ColorSpace.o: In function
`unsigned char cfVividLight<unsigned char>(unsigned char, unsigned char)':
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0x27): undefined
reference to `KoColorSpaceMathsTraits<unsigned char>::unitValue'
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0x33): undefined
reference to `KoColorSpaceMathsTraits<unsigned char>::zeroValue'
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0x97): undefined
reference to `KoColorSpaceMathsTraits<unsigned char>::zeroValue'
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0xa3): undefined
reference to `KoColorSpaceMathsTraits<unsigned char>::unitValue'
collect2: ld returned 1 exit status
make[2]: *** [lib/libpigmentcms.so.8.0.0] Fehler 1
make[1]: *** [libs/pigment/CMakeFiles/pigmentcms.dir/all] Fehler 2
make: *** [all] Fehler 2
[Attachment #5 (text/html)]
<div class="gmail_quote">On Sun, Feb 6, 2011 at 11:37 PM, Silvio Heinrich <span \
dir="ltr"><<a href="mailto:plassy@web.de">plassy@web.de</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000"><div class="im">
On 02/06/2011 10:56 PM, Sven Langkamp wrote:<br>
<blockquote type="cite">
<div bgcolor="#ffffff" text="#000000">What compiler version do you
use?<br>
</div>
<div class="gmail_quote">
<div><br>
gcc 4.4.3<br>
</div>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div \
bgcolor="#ffffff" text="#000000">And can you please try to add this include to the \
top of the libs/pigment/compositeops/KoCompositeOps.h header:<br>
<br>
<tt>#include "KoColorSpaceMaths.h"</tt><br>
<br>
and compile again.<br>
</div>
</blockquote>
<div><br>
Doesn't work. <br>
</div>
</div>
<br>
</blockquote></div>
Argg.. I hate when something like this happens :-/.<br>
I think we have to back-trace this then.<br>
It would be nice if you could erase the entire content of
libs/pigment/compositeops/KoCompositeOps.h and try<br>
this two versions instead:<br>
<br>
<tt>#ifndef _KO_COMPOSITEOPS_H_<br>
#define _KO_COMPOSITEOPS_H_<br>
<br>
#include "KoColorSpace.h"<br>
#include "KoColorSpaceTraits.h"<br>
#include "KoCompositeOp.h"<br>
#include "compositeops/KoCompositeOpFunctions.h"<br>
#include "compositeops/KoCompositeOpGeneric.h"<br>
<br>
template<class Traits><br>
void addStandardCompositeOps(KoColorSpace* cs)<br>
{<br>
cs->addCompositeOp(new KoCompositeOpGenericSC<Traits,
&cfVividLight>(cs, COMPOSITE_VIVID_LIGHT, i18n("Vivid
Light"), KoCompositeOp::categoryLight(), true));<br>
}<br>
<br>
<br>
// _KO_COMPOSITEOPS_H_</tt><br>
<br>
<br>
and:<br>
<br>
<tt>#ifndef _KO_COMPOSITEOPS_H_<br>
#define _KO_COMPOSITEOPS_H_<br>
<br>
#include "KoColorSpace.h"<br>
#include "KoColorSpaceTraits.h"<br>
#include "KoCompositeOp.h"<br>
#include "compositeops/KoCompositeOpFunctions.h"<br>
#include "compositeops/KoCompositeOpGeneric.h"<br>
<br>
template<class Traits><br>
void addStandardCompositeOps(KoColorSpace* cs)<br>
{<br>
typedef typename Traits::channels_type Arg;<br>
cs->addCompositeOp(new KoCompositeOpGenericSC< Traits,
&cfVividLight<Arg> >(cs, COMPOSITE_VIVID_LIGHT,
i18n("Vivid Light"), KoCompositeOp::categoryLight(), true));<br>
}<br>
<br>
<br>
// _KO_COMPOSITEOPS_H_</tt><br>
<br>
If you get some compiling errors instead of linking errors I made
some mistake :D but I hope it will compile.<br>
So, please try the two versions an tell me what errors you get :D<br>
I have gcc 4.4.5 but I can just hardly believe that 4.4.3 isn't able
to compile this :/<br>
<br>
</div>
<br></blockquote><div><br>In both cases I get:<br> \
<br></div></div>CMakeFiles/pigmentcms.dir/colorspaces/KoLabColorSpace.o: In function \
`unsigned short cfVividLight<unsigned short>(unsigned short, unsigned \
short)': \
<br> KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short \
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0x31): undefined \
reference to `KoColorSpaceMathsTraits<unsigned short>::unitValue'<br> \
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short \
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0x3d): undefined \
reference to `KoColorSpaceMathsTraits<unsigned short>::zeroValue'<br> \
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short \
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0xb3): undefined \
reference to `KoColorSpaceMathsTraits<unsigned short>::zeroValue'<br> \
KoLabColorSpace.cpp:(.text._Z12cfVividLightItET_S0_S0_[unsigned short \
cfVividLight<unsigned short>(unsigned short, unsigned short)]+0xbf): undefined \
reference to `KoColorSpaceMathsTraits<unsigned \
short>::unitValue'<br>
CMakeFiles/pigmentcms.dir/colorspaces/KoRgbU8ColorSpace.o: In function `unsigned char \
cfVividLight<unsigned char>(unsigned char, unsigned \
char)':<br>KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char \
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0x27): undefined \
reference to `KoColorSpaceMathsTraits<unsigned char>::unitValue'<br> \
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char \
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0x33): undefined \
reference to `KoColorSpaceMathsTraits<unsigned char>::zeroValue'<br> \
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char \
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0x97): undefined \
reference to `KoColorSpaceMathsTraits<unsigned char>::zeroValue'<br> \
KoRgbU8ColorSpace.cpp:(.text._Z12cfVividLightIhET_S0_S0_[unsigned char \
cfVividLight<unsigned char>(unsigned char, unsigned char)]+0xa3): undefined \
reference to `KoColorSpaceMathsTraits<unsigned \
char>::unitValue'<br>
collect2: ld returned 1 exit status<br>make[2]: *** [lib/libpigmentcms.so.8.0.0] \
Fehler 1<br>make[1]: *** [libs/pigment/CMakeFiles/pigmentcms.dir/all] Fehler \
2<br>make: *** [all] Fehler 2<br><br><br>
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic