'Re: Branch: krita-canvasrotation-silvioheinrich'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Branch: krita-canvasrotation-silvioheinrich
From:       Silvio Heinrich <plassy () web ! de>
Date:       2011-02-06 17:19:54
Message-ID: 4D4ED83A.9060604 () web ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

On 02/06/2011 10:09 AM, Dmitry Kazakov wrote:
>
>>     Well, if some tests fail, it means that some other subsystem may
>>     fail because of changed guarantees. I think you need to write
>>     what coordinate systems you have now and how your QTransform
>>     objects reflect relations between these coordinate systems.
>     OK i maybe was a bit rash.
>     I reverted all changes and applied the commits again in another
>     arrangement and I changed a few things.
>     Now the tests really do pass, yay :D.
>
>
> That is good. Actually, the tests were my biggest concern. So now you 
> can merge freely =) And the renaming of that QTransform has made the 
> system more clear.
>
> Btw, could you take a look into the bug 
> https://bugs.kde.org/show_bug.cgi?id=265528 ? There is some problem 
> with autoscrolling in KoCanvasControllerWidget. I think it gets 
> non-rotated coordinates. This is not a regression from your patch, so 
> you can do it after the merge, if you want =)
>

Yes I can try to fix it but I think I first need to get a better 
understanding of how all this flake stuff works.

I wanted to make the zooming with the zoom actions (zooming with + & - 
keys) work like zooming
with the mose wheel (relative to the mouse position). But it seems that 
the KoCanvasControllerWidget handles
this internally somehow, so i wonder if I can simply switch this 
behavior on somehow for zooming with actions?

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#ffffff" text="#000000">
    On 02/06/2011 10:09 AM, Dmitry Kazakov wrote:
    <blockquote
      cite="mid:AANLkTimJ6Ldo5aM3F2n-xDhAvKqZpWo+Bt+F1PhRKuDR@mail.gmail.com"
      type="cite">
      <div class="gmail_quote">
        <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
          0.8ex; border-left: 1px solid rgb(204, 204, 204);
          padding-left: 1ex;">
          <div bgcolor="#ffffff" text="#000000">
            <div class="im">
              <blockquote type="cite">
                <div class="gmail_quote">
                  <div>Well, if some tests fail, it means that some
                    other subsystem may fail because of changed
                    guarantees. I think you need to write what
                    coordinate systems you have now and how your
                    QTransform objects reflect relations between these
                    coordinate systems.</div>
                </div>
              </blockquote>
            </div>
            OK i maybe was a bit rash.<br>
            I reverted all changes and applied the commits again in
            another arrangement and I changed a few things.<br>
            Now the tests really do pass, yay :D.</div>
        </blockquote>
        <div><br>
          That is good. Actually, the tests were my biggest concern. So
          now you can merge freely =) And the renaming of that
          QTransform has made the system more clear.<br>
        </div>
        <div class="im"><br>
          Btw, could you take a look into the bug <a
            moz-do-not-send="true"
            href="https://bugs.kde.org/show_bug.cgi?id=265528">https://bugs.kde.org/show_bug.cgi?id=265528</a>
  ? There is some problem with autoscrolling in
          KoCanvasControllerWidget. I think it gets non-rotated
          coordinates. This is not a regression from your patch, so you
          can do it after the merge, if you want =)<br>

          <br>
        </div>
      </div>
    </blockquote>
    <br>
    Yes I can try to fix it but I think I first need to get a better
    understanding of how all this flake stuff works.<br>
    <br>
    I wanted to make the zooming with the zoom actions (zooming with +
    &amp; - keys) work like zooming<br>
    with the mose wheel (relative to the mouse position). But it seems
    that the KoCanvasControllerWidget handles<br>
    this internally somehow, so i wonder if I can simply switch this
    behavior on somehow for zooming with actions?<br>
  </body>
</html>

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

[prev in list] [next in list] [prev in thread] [next in thread] 