[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: koffice/krita/image
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-11-07 9:02:54
Message-ID: AANLkTikRvdw7xuwYGM1hxePjyKL96jrRHd9pSfSxjfBO () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Nov 7, 2010 at 11:57 AM, Boudewijn Rempt <> wrote:

> On Sunday 07 November 2010, Dmitry Kazakov wrote:
> > SVN commit 1193814 by dkazakov:
> >
> > Deprecate KisImage::mergedImage() function
> >
> > It is intended to do a very strange thing (it doesn't guarantee
> > anything, because it can't even lock the image) and its functionality is
> > fully covered by other methods of KisImage. See a comment in the
> > header to get more info.
>
> Is it actually used anywhere at the moment? It's a survival from the good
> old 1.x days when life was simple and everything ran in the gui thread.
>

Yes, there are some places:
krita/plugins/extensions/dockers/defaultdockers/kis_imagerasteredcache.cc:
m_imageProjection = m_image->mergedImage();
krita/plugins/extensions/separate_channels/kis_channel_separator.cc:
src = image->mergedImage();
krita/plugins/paintops/libpaintop/kis_custom_brush_widget.cpp:
KisPaintDeviceSP dev = new KisPaintDevice(*m_image->mergedImage());
krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc:            dev =
currentImage()->mergedImage();
krita/plugins/tools/defaulttools/kis_tool_fill.cc:
fillPainter.fillPattern(startX, startY, currentImage()->mergedImage());
krita/plugins/tools/defaulttools/kis_tool_fill.cc:
fillPainter.fillColor(startX, startY, currentImage()->mergedImage());
krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc:
fillpainter.createFloodSelection(pos.x(), pos.y(),
currentImage()->mergedImage());
krita/ui/kis_custom_pattern.cc:    m_pattern = new
KisPattern(image->mergedImage().data(), 0, 0, image->width(),
image->height());

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><div class="gmail_quote">On Sun, Nov 7, 2010 at 11:57 AM, Boudewijn Rempt <span \
dir="ltr">&lt;&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin: \
0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> \
<div class="im">On Sunday 07 November 2010, Dmitry Kazakov wrote:<br> &gt; SVN commit \
1193814 by dkazakov:<br> &gt;<br>
&gt; Deprecate KisImage::mergedImage() function<br>
&gt;<br>
&gt; It is intended to do a very strange thing (it doesn&#39;t guarantee<br>
&gt; anything, because it can&#39;t even lock the image) and its functionality is<br>
&gt; fully covered by other methods of KisImage. See a comment in the<br>
&gt; header to get more info.<br>
<br>
</div>Is it actually used anywhere at the moment? It&#39;s a survival from the good \
old 1.x days when life was simple and everything ran in the gui thread.<br \
                clear="all"></blockquote><div><br>Yes, there are some places:<br>
krita/plugins/extensions/dockers/defaultdockers/kis_imagerasteredcache.cc:            \
m_imageProjection = m_image-&gt;mergedImage();<br>krita/plugins/extensions/separate_channels/kis_channel_separator.cc: \
                src = image-&gt;mergedImage();<br>
krita/plugins/paintops/libpaintop/kis_custom_brush_widget.cpp:               \
KisPaintDeviceSP dev = new \
KisPaintDevice(*m_image-&gt;mergedImage());<br>krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc: \
                dev = currentImage()-&gt;mergedImage();<br>
krita/plugins/tools/defaulttools/kis_tool_fill.cc:                       \
fillPainter.fillPattern(startX, startY, \
currentImage()-&gt;mergedImage());<br>krita/plugins/tools/defaulttools/kis_tool_fill.cc: \
                fillPainter.fillColor(startX, startY, \
                currentImage()-&gt;mergedImage());<br>
krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc:                     \
fillpainter.createFloodSelection(pos.x(), pos.y(), \
currentImage()-&gt;mergedImage());<br>krita/ui/kis_custom_pattern.cc:       m_pattern \
= new KisPattern(image-&gt;mergedImage().data(), 0, 0, image-&gt;width(), \
image-&gt;height());<br> </div></div><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]