[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Need help with testing KisTool patch
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-09-21 9:50:11
Message-ID: AANLkTin6Scr+t+Xywhei=gJiy2O_2KWG4FqoatHDP47D () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Now i've ported most of the tools to handle base class mouse events.

There are a few tools not ported yet. It'll be quite tricky to port
KisToolPath and the derieved tools (like selections and polylines), because
they use some KOffice stuff.

Dyna tool and Transform tool. I had to revert all my changes on them because
i got unresolvable merge conflicts there. So i'll have to port them again
later.

http://dimula73.narod.ru/tools_refactor.patch


Maybe, usage of conditionals and macros is not the best choice, but this was
the only thing i could imagine here. Maybe, usage of some KoInteractionTool
and it's strategies would be better way to implement it, but it'll be a
really huge change. I think we should think it over for 2.4. Do you have any
ideas about this?

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

Now i&#39;ve ported most of the tools to handle base class mouse events.<br>       \
<br>There are a few tools not ported yet. It&#39;ll be quite tricky to port \
KisToolPath and the derieved tools (like selections and polylines), because they use \
some KOffice stuff.<br> <br>Dyna tool and Transform tool. I had to revert all my \
changes on them because i got unresolvable merge conflicts there. So i&#39;ll have to \
port them again later.<br><br><a \
href="http://dimula73.narod.ru/tools_refactor.patch">http://dimula73.narod.ru/tools_refactor.patch</a><br>
 <br>       <br>Maybe, usage of conditionals and macros is not the best choice, but \
this was the only thing i could imagine here. Maybe, usage of some KoInteractionTool \
and it&#39;s strategies would be better way to implement it, but it&#39;ll be a \
really huge change. I think we should think it over for 2.4. Do you have any ideas \
about this?<br clear="all"> <br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]