[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Patch for thumbnail update in layerbox
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2010-09-19 12:56:20
Message-ID: AANLkTimnKRN1kkb4zQmoTq+T5LzZUjoeZwgvWLkQ+KGF () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Sep 19, 2010 at 2:53 PM, Dmitry Kazakov <dimula73@gmail.com> wrote:

>
>
> On Sun, Sep 19, 2010 at 4:41 PM, Sven Langkamp <sven.langkamp@gmail.com>wrote:
>
>> On Sun, Sep 19, 2010 at 2:28 PM, Boudewijn Rempt <boud@valdyas.org>wrote:
>>
>>> On Sunday 19 September 2010, Sven Langkamp wrote:
>>> > On Sun, Sep 19, 2010 at 2:20 PM, Boudewijn Rempt <boud@valdyas.org>
>>> wrote:
>>> >
>>> > > On Sunday 19 September 2010, Sven Langkamp wrote:
>>> > >
>>> > > > Yes, in some places we are still missing systemLocked. The layerbox
>>> can
>>> > > also
>>> > > > be used to find them ;)
>>> > >
>>> > > :-) But I don't think systemlocked makes sense for the freehand tool,
>>> > > especially since it will cause flicker of the toolbox on eveyr stroke
>>> > >
>>> >
>>> > You want it to update, but not to flicker? ;)
>>> > It can be changed by the timeout which is currently one second.
>>> >
>>>
>>> No, I'm not talking about the layerbox, I meant: doesn't setSystemLocked
>>> disable all the tools in the toolbox -- i.e., gray them out? If that happens
>>> on every stroke with the freehand tool the effect will be as distracting as
>>> the flickering of the paintop toolbar was after Adam's patch.
>>>
>>
>> Yes, they are grayed out. We could solve this by adding another parameter
>> that would block it for very short locks like tools.
>>
>
> I think adding parameters is the worst thing that we can do here =(
>

For what reason?

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sun, Sep 19, 2010 at 2:53 PM, Dmitry Kazakov <span \
dir="ltr">&lt;<a href="mailto:dimula73@gmail.com">dimula73@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div><div></div><div \
class="h5"><br><br><div class="gmail_quote">On Sun, Sep 19, 2010 at 4:41 PM, Sven \
Langkamp <span dir="ltr">&lt;<a href="mailto:sven.langkamp@gmail.com" \
target="_blank">sven.langkamp@gmail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> <div><div class="gmail_quote">On Sun, Sep 19, 2010 at \
2:28 PM, Boudewijn Rempt <span dir="ltr">&lt;<a href="mailto:boud@valdyas.org" \
target="_blank">boud@valdyas.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;">


<div>On Sunday 19 September 2010, Sven Langkamp wrote:<br>
&gt; On Sun, Sep 19, 2010 at 2:20 PM, Boudewijn Rempt &lt;<a \
href="mailto:boud@valdyas.org" target="_blank">boud@valdyas.org</a>&gt; wrote:<br> \
&gt;<br> &gt; &gt; On Sunday 19 September 2010, Sven Langkamp wrote:<br>
&gt; &gt;<br>
&gt; &gt; &gt; Yes, in some places we are still missing systemLocked. The layerbox \
can<br> &gt; &gt; also<br>
&gt; &gt; &gt; be used to find them ;)<br>
&gt; &gt;<br>
&gt; &gt; :-) But I don&#39;t think systemlocked makes sense for the freehand \
tool,<br> &gt; &gt; especially since it will cause flicker of the toolbox on eveyr \
stroke<br> &gt; &gt;<br>
&gt;<br>
&gt; You want it to update, but not to flicker? ;)<br>
&gt; It can be changed by the timeout which is currently one second.<br>
&gt;<br>
<br>
</div>No, I&#39;m not talking about the layerbox, I meant: doesn&#39;t \
setSystemLocked disable all the tools in the toolbox -- i.e., gray them out? If that \
happens on every stroke with the freehand tool the effect will be as distracting as \
the flickering of the paintop toolbar was after Adam&#39;s patch.<br>


</blockquote></div><br></div>Yes, they are grayed out. We could solve this by adding \
another parameter that would block it for very short locks like tools.<br \
clear="all"></blockquote></div><br></div></div>I think adding parameters is the worst \
thing that we can do here =(<br> </blockquote></div><br>For what reason?<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]