[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Paintop presets referencing brushes in files are not portable
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2010-09-11 21:27:55
Message-ID: AANLkTimGS7k40ktybXtaYTaF74wVbGWLCmp_Xr2OAB46 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Sep 11, 2010 at 6:10 PM, LukasT.dev@gmail.com
<lukast.dev@gmail.com>wrote:

> > > Currently we address the gbr brush in preset by full path. We might use
> > > just a name.
> >
> > Well the problem is that two different brushes could have the same name.
>
> I have idea for it. Krita is looking for the brushes in some specified
> paths
> (user brushes, installed brushes, create package, maybe some other I
> haven't
> noticed yet). Let's just save the name of the brush like
>
> <brush filename="coolBrush.gbr" md5="58afe7e809d281fb421e728363bd80cc">
>
> Where md5 is the finger print of the gbr/abr/anyOtherFormat brush file
> content.
> Because it might happen that you name some brush with the same name in user
> brush dir and in installed brush dir. We would look for the brush where md5
> and name match.
>
> Sven filled the bug report, that's why I'm opening this topic again :)
> https://bugs.kde.org/show_bug.cgi?id=250675
>

I think the idea is good to use md5 sums. It might be a problem if there are
some big brushes, so we should check how much time is needed to generate
these sums. In case of ABR brushes can be severeral brushes in the same
file, so you can't take the md5 from the file there.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sat, Sep 11, 2010 at 6:10 PM, <a \
href="mailto:LukasT.dev@gmail.com">LukasT.dev@gmail.com</a> <span dir="ltr">&lt;<a \
href="mailto:lukast.dev@gmail.com">lukast.dev@gmail.com</a>&gt;</span> wrote:<br> \
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px \
solid rgb(204, 204, 204); padding-left: 1ex;">&gt; &gt; Currently we address the gbr \
brush in preset by full path. We might use<br> &gt; &gt; just a name.<br>
&gt;<br>
&gt; Well the problem is that two different brushes could have the same name.<br>
<br>
I have idea for it. Krita is looking for the brushes in some specified paths<br>
(user brushes, installed brushes, create package, maybe some other I haven&#39;t<br>
noticed yet). Let&#39;s just save the name of the brush like<br>
<br>
&lt;brush filename=&quot;coolBrush.gbr&quot; \
md5=&quot;58afe7e809d281fb421e728363bd80cc&quot;&gt;<br> <br>
Where md5 is the finger print of the gbr/abr/anyOtherFormat brush file content.<br>
Because it might happen that you name some brush with the same name in user<br>
brush dir and in installed brush dir. We would look for the brush where md5<br>
and name match.<br>
<br>
Sven filled the bug report, that&#39;s why I&#39;m opening this topic again :)<br>
<a href="https://bugs.kde.org/show_bug.cgi?id=250675" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=250675</a><br></blockquote><div><br>I \
think the idea is good to use md5 sums. It might be a problem if there are some big \
brushes, so we should check how much time is needed to generate these sums. In case \
of ABR brushes can be severeral brushes in the same file, so you can&#39;t take the \
md5 from the file there.<br> </div></div>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]