'Re: Canvas rotation preliminary patch'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Canvas rotation preliminary patch
From:       enki <enkithan () free ! fr>
Date:       2010-08-13 11:04:02
Message-ID: 4C6526A2.80801 () free ! fr
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

  On 13/08/2010 10:21, Dmitry Kazakov wrote:
> Hi, All!
>
> The reviewboard seems to be down right now, so i'm sending the patch here.
> http://dimula73.narod.ru/coordinates_refactor_v6.patch
>
> What is implemented:
> o Mirroring Ctrl+I
> o Rotation Ctrl+[, Ctrl+]
> o Reset canvas Ctrl+'
good job!
>
> Known bugs:
> 1) I still do not change the scroll area of KoCanvasController, so the 
> canvas picture may be cropped when rotated
> 2) There is a strange bug:
>     1. Switch to openGL canvas
>     2. Switch back QPainter canvas
>     3. Open configuration dialog, do not change anything, press ok
>     4. Try to zoom: KisPrescaledProjection in NOT updated
>
> I don't know what is the reason of this bug yet, but it's really 
> difficult to reproduce ;)
>
I encountered these bugs :

* Pan tool becomes erratic when the canvas has a 90 ° rotation.
* If the image is elongated, it's impossible to move the view to some 
areas of the image (apart from zooming out). You can also see that 
Scrollbars around the viewport don't change with rotation.
* The brush resizing gesture (SHIFT + LMB) rotates with the canvas. So 
if you rotate of 90 °, you have to move up/down instead of moving 
left/right to resize the brush.

I only tested with OpenGL canvas for now.
>
> -- 
> Dmitry Kazakov
>
>
> _______________________________________________
> kimageshop mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
    <title></title>
  </head>
  <body bgcolor="#ffffff" text="#000000">
    On 13/08/2010 10:21, Dmitry Kazakov wrote:
    <blockquote
      cite="mid:AANLkTi=Fy5K6Gi2mDm2bfzUizqH71faAasktTGoPsB=X@mail.gmail.com"
      type="cite">Hi, All!<br>
      <br>
      The reviewboard seems to be down right now, so i'm sending the
      patch here.<br>
      <a moz-do-not-send="true"
        href="http://dimula73.narod.ru/coordinates_refactor_v6.patch">http://dimula73.narod.ru/coordinates_refactor_v6.patch</a><br>
  <br>
      What is implemented:<br>
      o Mirroring Ctrl+I<br>
      o Rotation Ctrl+[, Ctrl+]<br clear="all">
      o Reset canvas Ctrl+'<br>
    </blockquote>
    good job!<br>
    <blockquote
      cite="mid:AANLkTi=Fy5K6Gi2mDm2bfzUizqH71faAasktTGoPsB=X@mail.gmail.com"
      type="cite"><br>
      Known bugs:<br>
      1) I still do not change the scroll area of KoCanvasController, so
      the canvas picture may be cropped when rotated<br>
      2) There is a strange bug: <br>
          1. Switch to openGL canvas<br>
          2. Switch back QPainter canvas<br>
          3. Open configuration dialog, do not change anything, press ok<br>
          4. Try to zoom: KisPrescaledProjection in NOT updated<br>
      <br>
      I don't know what is the reason of this bug yet, but it's really
      difficult to reproduce ;)<br>
      <br>
    </blockquote>
    I encountered these bugs :<br>
    <br>
    * Pan tool becomes erratic when the canvas has a 90° rotation.<br>
    * If the image is elongated, it's impossible to move the view to
    some areas of the image (apart from zooming out). You can also see
    that Scrollbars around the viewport don't change with rotation.<br>
    * The brush resizing gesture (SHIFT + LMB) rotates with the canvas.
    So if you rotate of 90°, you have to move up/down instead of moving
    left/right to resize the brush.<br>
    <br>
    I only tested with OpenGL canvas for now.
    <blockquote
      cite="mid:AANLkTi=Fy5K6Gi2mDm2bfzUizqH71faAasktTGoPsB=X@mail.gmail.com"
      type="cite"><br>
      -- <br>
      Dmitry Kazakov<br>
      <pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
kimageshop mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:kimageshop@kde.org">kimageshop@kde.org</a> <a \
class="moz-txt-link-freetext" \
href="https://mail.kde.org/mailman/listinfo/kimageshop">https://mail.kde.org/mailman/listinfo/kimageshop</a>
 </pre>
    </blockquote>
    <br>
  </body>
</html>

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

[prev in list] [next in list] [prev in thread] [next in thread] 