[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Rename for KisImage color space conversion interface
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-06-09 11:24:31
Message-ID: AANLkTikYFrg04phQxqZgWWsDokxdjRbWl497-dl-t8aR () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


After a short discussion on IRC we concluded that current interface can be
changed to be easier to understand:

Here is a proposal of new naming:

KisImage::convertImageColorSpace(const KoColorSpace *dstColorSpace,
KoColorConversionTransformation::Intent renderingIntent)
converts color space of all the nodes of the image and image's projection

KisImage::assingImageProfile(const KoColorProfile *profile)
assigns a new profile to every node.
^^ this is very disputable, because the user can get unexpected results if
his stack contains a mix of different color spaces. Should we leave it?

KisImage::convertRootLayerColorSpace(const KoColorSpace *dstColorSpace,
KoColorConversionTransformation::Intent renderingIntent)
or
KisImage::convertProjectionColorSpace(const KoColorSpace *dstColorSpace,
KoColorConversionTransformation::Intent renderingIntent)
converts rootLayer->projection() only. All the other layers are untouched.

KisImage::assingProjectionProfile(const KoColorProfile *profile)
assigns a new profile to rootLayer->projection() only. All the other layers
are untouched.



-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

After a short discussion on IRC we concluded that current interface can be changed to \
be easier to understand:<br><br>Here is a proposal of new \
naming:<br><br>KisImage::convertImageColorSpace(const KoColorSpace *dstColorSpace, \
KoColorConversionTransformation::Intent renderingIntent)<br> converts color space of \
all the nodes of the image and image&#39;s \
projection<br><br>KisImage::assingImageProfile(const KoColorProfile \
*profile)<br>assigns a new profile to every node. <br>^^ this is very disputable, \
because the user can get unexpected results if his stack contains a mix of different \
color spaces. Should we leave it?<br> <br>KisImage::convertRootLayerColorSpace(const \
KoColorSpace *dstColorSpace,  KoColorConversionTransformation::Intent \
renderingIntent)<br>or<br>KisImage::convertProjectionColorSpace(const KoColorSpace \
*dstColorSpace,  KoColorConversionTransformation::Intent renderingIntent)<br>converts \
rootLayer-&gt;projection() only. All the other layers are untouched.<br> \
<br>KisImage::assingProjectionProfile(const KoColorProfile *profile)<br>assigns a new \
profile to rootLayer-&gt;projection() only. All the other layers are  \
untouched.<br><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]