[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Clean-up for KisLayerManager and KisMaskManager
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-04-17 19:20:46
Message-ID: 201004172120.46393.boud () valdyas ! org
[Download RAW message or body]

On Friday 16 April 2010, Dmitry Kazakov wrote:
> Hi, All!
> 
> Here is a patch that clean-ups/fixes some flaws in layer creation part. I
> don't know where to commit it actually: trunk or koffice-ko...
> 
> What it does:
> 
>  o Fixes a memory leak in KisMaskManager when the creation of the mask
>     is canceled
>  o Removed superfluous setDirty() from both managers those caused double
>     updates of the image when creating the layer
>  o Moved activateNode functionality to KisNodeManager

All this sounds like trunk...


>  o Removed deprecated default functions for creating layers and
>     masks. Now the parent of the new mask is chosen by
>     KisNodeManager::getNewNodeLocation.


But this sounds like the branch.

In the end, the memory leak is the important thing, so if you cannot split it, 
it should go into trunk, I think.

-- 
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]