[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Patch: don't save tiles that are equal to the default tile
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-03-16 15:36:21
Message-ID: ae32c1ef1003160836j50b84242l5b86281686691f16 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


>
> I think it happened to me after a call to clearSelection, that can happen
> either by calling edit->clear, or edit->cut. It can also happen after the
> use
> of the eraser tool.
>

Selections and cutting should use KisDataManager::clear(), through
KisPaintDevice::fill() [1]. This method uses tiles to fill the rect and
substitutes default tile, if the fill-pixel is default.

The eraser tool can use clear() too.

PS:
[1] - btw, we still don't have a fill() method of KisPaintDevice that takes
a parameter of a QRect instead of pure digits. That is quite uncomfortable.

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">I think it \
happened to me after a call to clearSelection, that can happen<br>

either by calling edit-&gt;clear, or edit-&gt;cut. It can also happen after the \
use<br> of the eraser tool.<br>
</blockquote></div><br>Selections and cutting should use KisDataManager::clear(), \
through KisPaintDevice::fill() [1]. This method uses tiles to fill the rect and \
substitutes default tile, if the fill-pixel is default.<br> <br>The eraser tool can \
use clear() too.<br><br>PS:<br>[1] - btw, we still don&#39;t have a fill() method of \
KisPaintDevice that takes a parameter of a QRect instead of pure digits. That is \
quite uncomfortable.<br><br>-- <br> Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]