[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: KisSliderSpinBox api change
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2010-03-16 0:20:37
Message-ID: 478b087a1003151720t7244f2afq1aa1417d8e18ce54 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Mar 15, 2010 at 12:07 AM, Cyrille Berger <cberger@cberger.net>wrote:

> On Saturday 13 March 2010, Cyrille Berger wrote:
> > On Saturday 13 March 2010, Sven Langkamp wrote:
> > > On Sat, Mar 13, 2010 at 9:23 AM, Boudewijn Rempt <boud@valdyas.org>
> wrote:
> > > > Does this make it impossible to use the slider for integer values? We
> > > > have a
> > > > number of places where we use integers, like opacity etc.
> > >
> > > Not impossible, you could set decimals to 0 and round the resulting
> > > values. If we don't make the change than you have to be careful to use
> > > the right method.
> > > At the moment e.g. the gradient tool threshold is broken because of
> that.
> >
> > Wouldn't it be possible to have two classes, one for integer and one for
> > float ? (with a base class to share everything)
> Here is a patch with two classes. Could do with even more cleanup, but
> looks
> functional to me.
>
>
Looks good. The only thing I noticed was that the m_slPreviewOpacity is a
KisSliderSpinBox, but uses the qreal signal.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Mon, Mar 15, 2010 at 12:07 AM, Cyrille Berger <span \
dir="ltr">&lt;<a href="mailto:cberger@cberger.net">cberger@cberger.net</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im">On \
Saturday 13 March 2010, Cyrille Berger wrote:<br> &gt; On Saturday 13 March 2010, \
Sven Langkamp wrote:<br> &gt; &gt; On Sat, Mar 13, 2010 at 9:23 AM, Boudewijn Rempt \
&lt;<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>&gt; wrote:<br> &gt; &gt; \
&gt; Does this make it impossible to use the slider for integer values? We<br> &gt; \
&gt; &gt; have a<br> &gt; &gt; &gt; number of places where we use integers, like \
opacity etc.<br> &gt; &gt;<br>
&gt; &gt; Not impossible, you could set decimals to 0 and round the resulting<br>
&gt; &gt; values. If we don&#39;t make the change than you have to be careful to \
use<br> &gt; &gt; the right method.<br>
&gt; &gt; At the moment e.g. the gradient tool threshold is broken because of \
that.<br> &gt;<br>
&gt; Wouldn&#39;t it be possible to have two classes, one for integer and one for<br>
&gt; float ? (with a base class to share everything)<br>
</div>Here is a patch with two classes. Could do with even more cleanup, but \
looks<br> functional to me.<br>
<br></blockquote><div><br>Looks good. The only thing I noticed was that the \
m_slPreviewOpacity is a KisSliderSpinBox, but uses the qreal signal. </div></div>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]