[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: KisSliderSpinBox api change
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-03-13 8:23:39
Message-ID: 201003130923.39494.boud () valdyas ! org
[Download RAW message or body]

On Saturday 13 March 2010, Sven Langkamp wrote:
> Hi,
> 
> when looking at the recent changes to use the new slider I found several
> places where is wasn't used correctly. (using the integer methods that does
> consider the factor)
> Therefor I propose the api changed in the attached patch. By not longer
> inheriting from QAbstractSlider it hides the internal api.
> 
> That way we can still use the current value/setValue and valueChanged
> signal.
> 
> When changing a slider the signal connection needs to be checked, because
> the old slider often had different parameter there.
> I know it's a bit stupid to change it now, but it reduces the risk of using
> the api in the wrong way.

Does this make it impossible to use the slider for integer values? We have a 
number of places where we use integers, like opacity etc.

-- 
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]