On Saturday 30 January 2010, PEGON Marc wrote: > I'm trying to make the local selections work according to > https://bugs.kde.org/show_bug.cgi?id=210865 > But the way these local selections should work is still quite vague, so > i would like your advice, especially about boud's suggestion to add a > third icon to enable/disable selection... > Some people are concerned about the fact that a third icon might make > the use of local selections too complicated for users, however, i'm not > sure it's possible to handle the local selections nicely only with the > visibility icon (plus marching ant animation are sometimes disturbing, > and people want to be able to hide it without disabling the selection). Yes, that's the reason. I don't think an extra icon nin the layerbox is such a big thing. I also added the alpha lock icon for ordinary layers, and I'm sure there will be some more for things as yet unforeseen. > Also, i'm not sure what the actions "Deselect" and "Deselect all" should > do in particular cases. For example, if i make a selection (a global > selection), and then create a local selection mask from this global > selection, then i have 2 selections enabled at the same time : the > global selection, and the local selection (which are the same). It's the > local selection which is used preferentially : if a local selection > exists and is enabled, then it's the one which is returned by > KisLayer::selection(). But then, what should the "Deselect" action do ? > Disable the local selection ? Disable the global selection ? Remove the global selection, I'd say. The local selection can be removed with the delete node button in the layerbox. > Problem is, whether we choose to disable the local selection or the > global selection, we would have to do "Deselect" twice in order to see a > difference : indeed, if you disable the global selection, the local > selection remains here and enabled, so you have to do "deselect" on more > time to deselect the local selection. I don't think that deselect should work on local selections. Deleting the node seems more intuitive to me. > So maybe we should Disable both ? (but then we would have to add a new > kis command since neither kis_deselect_local_selection_command nor > kis_deselect_global_selection_command matches this new command). > Another solution is to disable the global selection when creating a > local selection from it, or when enabling an existing local selection, > so that there are never a global selection and a local selection active > at the same time. Hm, that might actually work pretty well. I guess we could make a config setting for that behaviour, so we can experiment with it. > Another thing : what should happen when using the selection tool ? > should it modify the current local selection if one is enabled, and > create a global selection if none is enabled ? Yes -- and if the local selection is selected in the layerbox, the painting tools should work on it. > > I really need clarifications on this to do anything. Thanks ! Thanks for your effort, and I'm really sorry I wasn't available this weekend :-(. -- Boudewijn Rempt | http://www.valdyas.org _______________________________________________ kimageshop mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop