[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Review Request: Krita: Gaussian Blur Filter
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2009-12-14 19:08:03
Message-ID: 200912142008.04294.boud () valdyas ! org
[Download RAW message or body]

On Monday 14 December 2009, you wrote:
> > On 2009-12-14 09:07:09, Boudewijn Rempt wrote:
> > > Hm... I think you have forgotten to compile and run the unittests with
> > > your patch.
> >
> > antiquark wrote:
> >     Yes, I'm applying the necessary modifications now.
> >
> >     Regarding the large kernel issue, I was specifically commenting about
> > the new Gaussian Blur filter. Other filters seem to be unaffected. I
> > suspect it has something to do with performing two convolutions, one
> > after the other.
> >
> > Boudewijn Rempt wrote:
> >     Ok -- so either we'd need to figure out what's going on, or limit the
> > kernel size in the settings widget, right?
> >
> > antiquark wrote:
> >     Yes, although I don't think it's a good idea to limit the blur
> > radius.
> 
> I might know the reason why it works wrong.
> Doesn't it look like "border effect"? If so this is surely due to threading
>  of filters. I'm working on this. To prove the fault of threading try limit
>  thread number to 1.

In that case, if you and Cyrille agree as well, I think the patch can go in.

-- 
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]