[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: koffice/krita/image
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2009-11-25 19:21:56
Message-ID: ae32c1ef0911251121i18afbbafw4e58d5f5d245407d () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


>
> > paintDevice stores selection of the mask instead of the result image. Is
> it
> > expected behavior?
> Yes, that is what gimp and photoshop show too. And with boudewijn we
> concluded
> that it is what makes most sense. If we want to show a preview of the
> applied
> result, we could show it in the tooltip.
>

Ok, thanks. I was a bit of confused because of copy-paste naming =)

Maybe:
s/originalDevice/selection



>
> > Could you explain why is thumbnail created from paintDevice() instead of
> > original()?
> Isn't the original of a mask null ? Because my first attempt was to use
> "original()" (actually moving the thumbnail code from KisLayer to
> KisBaseNode), since I expected the data of the mask to be in "original()",
> but
> I got a null "original()" for the transparency mask.
>

Sorry, i got remembered that KisMask does not inherit KisLayer too late to
write =)

For Boud:
Boud, could you revert this misleading part of r1030899 and move original()
and projection() back to KisLayer as pure virtual methods? I've been writing
to you about that already... original() and projection() is nothing for
masks so they shouldn't be present in KisNode and return bogus values...




-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div \
class="im"> &gt; paintDevice stores selection of the mask instead of the result \
image. Is it<br> &gt; expected behavior?<br>
</div>Yes, that is what gimp and photoshop show too. And with boudewijn we \
concluded<br> that it is what makes most sense. If we want to show a preview of the \
applied<br> result, we could show it in the tooltip.<br></blockquote><div><br>Ok, \
thanks. I was a bit of confused because of copy-paste naming \
=)<br><br>Maybe:<br>s/originalDevice/selection<br><br>  </div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">

<div class="im"><br>
&gt; Could you explain why is thumbnail created from paintDevice() instead of<br>
&gt; original()?<br>
</div>Isn&#39;t the original of a mask null ? Because my first attempt was to use<br>
&quot;original()&quot; (actually moving the thumbnail code from KisLayer to<br>
KisBaseNode), since I expected the data of the mask to be in &quot;original()&quot;, \
but<br> I got a null &quot;original()&quot; for the transparency mask.<font \
color="#888888"><br> </font></blockquote><div><br>Sorry, i got remembered that \
KisMask does not inherit KisLayer too late to write =)<br><br>For Boud:<br>Boud, \
could you revert this misleading part of r1030899 and move original() and \
projection() back to KisLayer as pure virtual methods? I&#39;ve been writing to you \
about that already... original() and projection() is nothing for masks so they \
shouldn&#39;t be present in KisNode and return bogus values...<br> \
<br></div></div><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]