[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Review request: Masks support compositeOps and opacity
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2009-10-28 17:03:01
Message-ID: ae32c1ef0910281003l519311a2jb903bd8be3b100ff () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


>
>
> > I've done tests. Kis{,Base}Node tests are done successfully, but some
> Masks
> > and Selections tests fail with segmentation. Could you check whether this
> >  is a regression or not?
>
> well, they didn't fail when we branched 2.1: in fact, we had 100% success
> on
> all tests at that moment. However, I enabled your tile engine and the
> pyramid,
> and that caused some tests to fail.


Wait.. My working copy doesn't have new tile engine enabled! It hasn't been
updated to your commit yet! So, that is not the reason =)

 I can check whether there are more

> failures with this patch, of course.
>
> Btw, since enabling the new tile engine, saving is broken. I think Lukas is
> creating a bug for that.
>
Strange, saving worked in August.



-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div \
class="h5"><br> &gt; I&#39;ve done tests. Kis{,Base}Node tests are done successfully, \
but some Masks<br> &gt; and Selections tests fail with segmentation. Could you check \
whether this<br> &gt;   is a regression or not?<br>
<br>
</div></div>well, they didn&#39;t fail when we branched 2.1: in fact, we had 100% \
success on<br> all tests at that moment. However, I enabled your tile engine and the \
pyramid,<br> and that caused some tests to fail.</blockquote><div><br>Wait.. My \
working copy doesn&#39;t have new tile engine enabled! It hasn&#39;t been updated to \
your commit yet! So, that is not the reason =)<br><br>  I can check whether there are \
more<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> failures with this patch, \
of course.<br> <br>
Btw, since enabling the new tile engine, saving is broken. I think Lukas is<br>
creating a bug for that.<br>
</blockquote></div>Strange, saving worked in August.<br><br><br clear="all"><br>-- \
<br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]