[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: blur & masks
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2009-09-30 19:45:06
Message-ID: ae32c1ef0909301245ra4764f0v6a6e39b8004bece3 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Sep 30, 2009 at 11:17 PM, Boudewijn Rempt <boud@valdyas.org> wrote:
> On Wednesday 30 September 2009, Cyrille Berger wrote:
> > On Wednesday 30 September 2009, Boudewijn Rempt wrote:
> > > Hi,
> > >
> > > Dmitry asked me to look at why the blur filter doesn't work with masks,
> > > and I think I've at least got a lead: it looks like none of the
> > > convolution-based filters work with masks. Saving the src and dst
> > > paint devices in the process() method shows that dst _is_ blurred --
> > > but there is something else going on.
> >
> > the blur filter absolutely need a KisTransaction to be created prior to
> > applying the filter, is it the case ? (that said, without the
> > kistransaction you would get garbage in the output, not nothing)
>
> Good point, I'll check that.
>
It should be placed in KisFilterMask::decorateRect(). Maybe, there are two
transactions created at once? In KisMask::apply and in
KisFilterMask::decorateRect? I don't have code to check atm.
--
Dmitry Kazakov
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">On Wed, Sep 30, 2009 at 11:17 PM, \
Boudewijn Rempt <span dir="ltr"><<a \
href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid \
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div \
class="im">On Wednesday 30 September 2009, Cyrille Berger wrote:<br> > \
On Wednesday 30 September 2009, Boudewijn Rempt wrote:<br> > > \
Hi,<br> > ><br>
> > Dmitry asked me to look at why the blur filter doesn't work \
with masks,<br> > > and I think I've at least got a lead: it \
looks like none of the<br> > > convolution-based filters work with \
masks. Saving the src and dst<br> > > paint devices in the process() \
method shows that dst _is_ blurred --<br> > > but there is something \
else going on.<br> ><br>
> the blur filter absolutely need a KisTransaction to be created prior \
to<br> > applying the filter, is it the case ? (that said, without \
the<br> > kistransaction you would get garbage in the output, not \
nothing)<br> <br>
</div>Good point, I'll check that.<br></blockquote><div><br>It should \
be placed in KisFilterMask::decorateRect(). Maybe, there are two \
transactions created at once? In KisMask::apply and in \
KisFilterMask::decorateRect? I don't have code to check atm.<br> \
</div><div><br><br></div></div><br><br clear="all"><br>-- <br>Dmitry \
Kazakov<br>
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic