--===============1550739615==
Content-Type: multipart/alternative; boundary=001485f6c5c6bcf72a0474907988

--001485f6c5c6bcf72a0474907988
Content-Type: text/plain; charset=UTF-8

On Sat, Sep 26, 2009 at 10:11 AM, Boudewijn Rempt <boud@valdyas.org> wrote:

> SVN commit 1028181 by rempt:
>
> Fix layer test
>
> We used to leak the KisProjection, which meant that for every image opened
> and closed we would leave a thread with an eventloop running. However,
> stopping
> that thread reliably is quite hard, so try really hard to stop it.
>
>  M  +3 -1      kis_image.cc
>  M  +11 -1     kis_projection.cc
>  M  +1 -0      kis_projection.h
>  M  +4 -0      tests/kis_layer_test.cpp
>



> +void KisProjection::stop()
> +{
> +    quit();
> +    while(isRunning()) {
> +        qApp->processEvents();
> +    }
> +    setTerminationEnabled(true);
> +    terminate();
> +}
> +
>

This 'while' loop with processEvents() causes infinite loop in
KisCropVisitorTest. Please check this! =)




-- 
Dmitry Kazakov

--001485f6c5c6bcf72a0474907988
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Sat, Sep 26, 2009 at 10:11 AM, Boudew=
ijn Rempt <span dir=3D"ltr">&lt;<a href=3D"mailto:boud@valdyas.org">boud@va=
ldyas.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; p=
adding-left: 1ex;">
SVN commit 1028181 by rempt:<br>
<br>
Fix layer test<br>
<br>
We used to leak the KisProjection, which meant that for every image opened<=
br>
and closed we would leave a thread with an eventloop running. However, stop=
ping<br>
that thread reliably is quite hard, so try really hard to stop it.<br>
<br>
=C2=A0M =C2=A0+3 -1 =C2=A0 =C2=A0 =C2=A0kis_image.cc<br>
=C2=A0M =C2=A0+11 -1 =C2=A0 =C2=A0 kis_projection.cc<br>
=C2=A0M =C2=A0+1 -0 =C2=A0 =C2=A0 =C2=A0kis_projection.h<br>
=C2=A0M =C2=A0+4 -0 =C2=A0 =C2=A0 =C2=A0tests/kis_layer_test.cpp<br></block=
quote><div><br>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"borde=
r-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-le=
ft: 1ex;">

+void KisProjection::stop()<br>
+{<br>
+ =C2=A0 =C2=A0quit();<br>
+ =C2=A0 =C2=A0while(isRunning()) {<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0qApp-&gt;processEvents();<br>
+ =C2=A0 =C2=A0}<br>
+ =C2=A0 =C2=A0setTerminationEnabled(true);<br>
+ =C2=A0 =C2=A0terminate();<br>
+}<br>
+<br></blockquote><div><br>This &#39;while&#39; loop with processEvents() c=
auses infinite loop in KisCropVisitorTest. Please check this! =3D)<br><br>=
=C2=A0<br></div></div><br clear=3D"all"><br>-- <br>Dmitry Kazakov<br>

--001485f6c5c6bcf72a0474907988--

--===============1550739615==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

--===============1550739615==--