[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: A first part of the layers/masks patch
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2009-09-26 17:58:19
Message-ID: ae32c1ef0909261058n76d5a0abvf02e921bc845c2b () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Sep 26, 2009 at 10:44 AM, Boudewijn Rempt <boud@valdyas.org> wrote:

> On Wednesday 23 September 2009, Dmitry Kazakov wrote:
>
> > This is a singlepatch version. It can be easily applied to trunk without
> > conflicts. It's good for testing, not for reading:
> > http://dimula73.narod.ru/01_layers_masks_refactoring_singlepatch.diff
>

Yes, recent commits broke it. I'm compiling newly merged one.



> There are a couple of stylistic issues I'm not too happy with, like
> rearranging the order of methods in a header and some renaming.

I just wanted to make them more readable by grouping resembling methods.



> Right now, for
> someone who's been working with Krita for a longer time, confusion is
> guaranteed between the term 'projection; and the new term 'cache'.
>

Btw, there is no new term 'cache' =) Do you mean
KisGroupLayer::resetCache()?
I changed it from resetProjection to resetCache because KisAdjustmentLayer
had already had similar method. They both should have the same name. And
their name can't be resetProjection because now they reset 'original' paint
device instead of 'projection'

I'll write about projections, originals and painDevices in a reply to your
next mail.


>
> These big refactors go better if we keep the renaming to the end, I think.
> I'm
> still digesting your other mail, it's as long as the patch!
>

=)


-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Sat, Sep 26, 2009 at 10:44 AM, Boudewijn Rempt \
<span dir="ltr">&lt;<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Wednesday 23 \
September 2009, Dmitry Kazakov wrote:<br> <br>
&gt; This is a singlepatch version. It can be easily applied to trunk without<br>
&gt; conflicts. It&#39;s good for testing, not for reading:<br>
&gt; <a href="http://dimula73.narod.ru/01_layers_masks_refactoring_singlepatch.diff" \
target="_blank">http://dimula73.narod.ru/01_layers_masks_refactoring_singlepatch.diff</a><br></div></blockquote><div><br>Yes, \
recent commits broke it. I&#39;m compiling newly merged one.<br> <br>  \
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"> </div>There are \
a couple of stylistic issues I&#39;m not too happy with, like<br> rearranging the \
order of methods in a header and some renaming.</blockquote><div>I just wanted to \
make them more readable by grouping resembling methods.<br><br>  </div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">  Right now, for<br>
someone who&#39;s been working with Krita for a longer time, confusion is<br>
guaranteed between the term &#39;projection; and the new term \
&#39;cache&#39;.<br></blockquote><div><br>Btw, there is no new term &#39;cache&#39; \
=) Do you mean KisGroupLayer::resetCache()?<br>I changed it from resetProjection to \
resetCache because KisAdjustmentLayer had already had similar method. They both \
should have the same name. And their name can&#39;t be resetProjection because now \
they reset &#39;original&#39; paint device instead of &#39;projection&#39;<br> \
<br>I&#39;ll write about projections, originals and painDevices in a reply to your \
next mail.<br>  </div><blockquote class="gmail_quote" style="border-left: 1px solid \
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

<br>
These big refactors go better if we keep the renaming to the end, I think. \
I&#39;m<br> still digesting your other mail, it&#39;s as long as the \
patch!<br></blockquote><div><br>=) <br></div></div><br clear="all"><br>-- <br>Dmitry \
Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]