[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: A first part of the layers/masks patch
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2009-09-26 17:19:52
Message-ID: ae32c1ef0909261019o22ba1b6cqecb60d0fe0d5fd50 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Sep 26, 2009 at 10:14 AM, Cyrille Berger <cberger@cberger.net>wrote:

> On Saturday 26 September 2009, Dmitry Kazakov wrote:
> > > for a,b,c) it doesn't work perfectly, but it's not that broken.
> >
> > But still not usable =(
> Well now, I have fix all the issue with the alpha colorspace (I have added
> alpha darken). All it remains to do is to make mask support the indirect
> painting interface.
>

Well, no. You've not fixed that. It's just a workaround.

Testcase:
1) Create any mask (e.g. transparency mask)
2) Paint something on a mask to get transparency

Let's imagine after these steps you decide to make some rect visible again,
what are you going to do? In a good editor you just select this rect with
selection and fill it with a white color (or any semi-transparent one(!)).
You CAN'T do the same with krita, as far as i can see. Yes, you can use
pixel eraser tool (that is not so obvious, btw), but what if your rect is
1024x1024 size? Are you gonna fill it with a small brush?

That's why i repeat again, we must use grayscale-like system for
transparency masks. Current discreet selection system is a dirty hack.



> It doesn't use the gray color, but this is by design, it means you have to
> use
> the opacity setting (this is something we have been debating in krita for
> years, wether opacity belongs in the tool or in the color selector).
> Gradient work if you choose a gradient with transparency, in a future
> release,
> it could be worth investigating adding an option to the gradient tool for
> working on the transparent channel instead of colors (I think it might have
> a
> broader use).
>

Do not create additional abstraction for a user. He knows what the color is,
this is RGB values. The user DOES NOT know anything about our INTERNAL
representation of the color as rgbA. RGB != RGBA. He knows (or should know)
_nothing_ about alpha channel of the brush or of the layer. It's editor's
job to think about alpha, not user's one!


PS:
Sorry for brute words. I don't know how to explain it. I repeat it again and
again...
We have a weird selections system and you don't even want to make it better.



-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Sat, Sep 26, 2009 at 10:14 AM, Cyrille Berger \
<span dir="ltr">&lt;<a \
href="mailto:cberger@cberger.net">cberger@cberger.net</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Saturday 26 \
September 2009, Dmitry Kazakov wrote:<br> &gt; &gt; for a,b,c) it doesn&#39;t work \
perfectly, but it&#39;s not that broken.<br> &gt;<br>
&gt; But still not usable =(<br>
</div>Well now, I have fix all the issue with the alpha colorspace (I have added<br>
alpha darken). All it remains to do is to make mask support the indirect<br>
painting interface.<br></blockquote><div><br>Well, no. You&#39;ve not fixed that. \
It&#39;s just a workaround.<br><br>Testcase:<br>1) Create any mask (e.g. transparency \
mask)<br>2) Paint something on a mask to get transparency<br> <br>Let&#39;s imagine \
after these steps you decide to make some rect visible again, what are you going to \
do? In a good editor you just select this rect with selection and fill it with a \
white color (or any semi-transparent one(!)). You CAN&#39;T do the same with krita, \
as far as i can see. Yes, you can use pixel eraser tool (that is not so obvious, \
btw), but what if your rect is 1024x1024 size? Are you gonna fill it with a small \
brush?<br>  <br>That&#39;s why i repeat again, we must use grayscale-like system for \
transparency masks. Current discreet selection system is a dirty hack.<br><br>  \
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">


It doesn&#39;t use the gray color, but this is by design, it means you have to \
use<br> the opacity setting (this is something we have been debating in krita for<br>
years, wether opacity belongs in the tool or in the color selector).<br>
Gradient work if you choose a gradient with transparency, in a future release,<br>
it could be worth investigating adding an option to the gradient tool for<br>
working on the transparent channel instead of colors (I think it might have a<br>
broader use).<br>
</blockquote></div><br>Do not create additional abstraction for a user. He knows what \
the color is, this is RGB values. The user DOES NOT know anything about our INTERNAL \
representation of the color as rgbA. RGB != RGBA. He knows (or should know) _nothing_ \
about alpha channel of the brush or of the layer. It&#39;s editor&#39;s job to think \
about alpha, not user&#39;s one!<br> <br><br>PS:<br>Sorry for brute words. I \
don&#39;t know how to explain it. I repeat it again and again... <br>We have a weird \
selections system and you don&#39;t even want to make it better. <br><br \
clear="all"><br>-- <br> Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic