[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Tool overlay and cursor shapes
From:       "LukasT.dev () gmail ! com" <lukast ! dev () gmail ! com>
Date:       2009-09-18 21:04:21
Message-ID: 200909182304.22183.LukasT.dev () gmail ! com
[Download RAW message or body]

On Friday 18 September 2009 14:38:34 Cyrille Berger wrote:
> On Friday 18 September 2009, LukasT.dev@gmail.com wrote:
> > On Friday 18 September 2009 08:03:46 Cyrille Berger wrote:
> > > On Friday 18 September 2009, LukasT.dev@gmail.com wrote:
> > > > Check it out. Just change line paintToolOutline(&gc,path); to
> > > > paintToolOutline(&gc,path,BW_MODE);
> > >
> > > one last change, I think the mode should be a variable in KisTool, not 
> > > a parameter of paintToolOutline.
> >
> > I made it a parameter so that every tool can decide if it wants to paint
> > in this mode or that mode. Default is XOR mode.
> >
> > Why would you like to have it as variable?
> 
> To not to have change each tools when we want to switch to a different type
>  of overlay.
> 
Should I ifdef the new code like 

#ifdef INDEPEDENT_CANVAS
newOutlinecode
#else
old code
#endif

Is the INDEPENDENT_CANVAS shipped with 2.1 or still not tested enough?
ifdefs are growing and are little annoying...
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]