[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Problems with "embedded" transparency masks onto adj. layers
From: Boudewijn Rempt <boud () valdyas ! org>
Date: 2009-09-09 6:38:10
Message-ID: 200909090838.10342.boud () valdyas ! org
[Download RAW message or body]
On Tuesday 08 September 2009, Dmitry Kazakov wrote:
> > It used to work just fine in 1.6, where we used an alpha8 colorspace and
> > COMPOSITE_OVER to paint on selections, I'm not sure I understand why this
> > would not work in 2.x. I definitely don't believe we need to double the
> > memory
> > requirements of selections to be able to paint on them: I think using a
> > different composite op should be enough.
>
> How are you intending to describe the shape of the brush without a separate
> alpha channel?
>
Well, we probably need to compare the current code to the code in 1.6, but
there it worked perfectly. This is how the selection brush worked in 1.6:
...
m_target = selection;
m_painter = new KisPainter(selection.data());
Q_CHECK_PTR(m_painter);
m_painter->setPaintColor(KisColor(Qt::black, selection->colorSpace()));
m_painter->setBrush(m_subject->currentBrush());
m_painter->setOpacity(OPACITY_OPAQUE);
m_painter->setCompositeOp(COMPOSITE_OVER);
KisPaintOp * op = KisPaintOpRegistry::instance()->paintOp("paintbrush", 0,
painter());
painter()->setPaintOp(op); // And now the painter owns the op and will
destroy it.
...
--
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic