[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Need some help with colorspaces
From: Cyrille Berger <cberger () cberger ! net>
Date: 2009-08-04 11:28:57
Message-ID: 200908041329.00885.cberger () cberger ! net
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tuesday 04 August 2009, Boudewijn Rempt wrote:
> On Tue, 4 Aug 2009, Dmitry Kazakov wrote:
> > > Does it happen with all colorspace ?
> >
> > I've just fixed the bug. =(
> > It is in KoColorSpace::bitBlt. There was some strange rowStride
> > post-calculation in it. The patch is in attachment. Should i put it to
> > reviewboard or just commit?
>
> Looks good to me. It would be wonderful to have a unittest for this in
> pigment... Althought bitblt is also tested in the krita/image unittests,
> but they have been failing for a long time.
Well we clearly need both tests :) so that we know which functions fails and
when. But I must admit total lazyness, especially given the relative few
number of bugs found (and therefor fixed) in pigment for more than a year ;) (I
know it's not an excuse :) )
--
Cyrille Berger
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">On Tuesday 04 August 2009, Boudewijn Rempt \
wrote:<br> > On Tue, 4 Aug 2009, Dmitry Kazakov wrote:<br>
> > > Does it happen with all colorspace ?<br>
> ><br>
> > I've just fixed the bug. =(<br>
> > It is in KoColorSpace::bitBlt. There was some strange rowStride<br>
> > post-calculation in it. The patch is in attachment. Should i put it to<br>
> > reviewboard or just commit?<br>
><br>
> Looks good to me. It would be wonderful to have a unittest for this in<br>
> pigment... Althought bitblt is also tested in the krita/image unittests,<br>
> but they have been failing for a long time.<br>
Well we clearly need both tests :) so that we know which functions fails and when. \
But I must admit total lazyness, especially given the relative few number of bugs \
found (and therefor fixed) in pigment for more than a year ;) (I know it's not an \
excuse :) )<br> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><br></p>-- <br> Cyrille Berger</p></body></html>
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic